Skip to content
This repository was archived by the owner on Mar 13, 2020. It is now read-only.

Commit d26b318

Browse files
authored
Merge pull request #69 from pageuppeople-opensource/task/SP-337_remove-null-character
[SP-337] Remove null characters
2 parents 1ac1fae + 3333c69 commit d26b318

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

rdl/BatchDataLoader.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@ def load_batch(self, batch_key_tracker):
6161
batch_key_tracker.has_more_data = False
6262
return
6363

64+
# replacing unicode null characters because postgres doesn't support null characters in text fields
65+
# https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.replace.html
66+
data_frame = data_frame.replace(regex=r"\x00", value="")
67+
6468
data_frame = self.attach_column_transformers(data_frame)
6569
self.write_data_frame_to_table(data_frame)
6670
batch_tracker.load_completed_successfully()

rdl/data_sources/AWSLambdaDataSource.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,7 @@ def __get_table_data(
145145
return result["ColumnNames"], data
146146

147147
def __get_data_frame(self, data: [[]], column_names: []):
148-
return pandas.DataFrame(data=data, columns=column_names).replace(
149-
regex=r"\x00", value=""
150-
)
148+
return pandas.DataFrame(data=data, columns=column_names)
151149

152150
def __invoke_lambda(self, pay_load):
153151
self.logger.debug("\nRequest being sent to Lambda:")

0 commit comments

Comments
 (0)