Skip to content
This repository was archived by the owner on Jul 2, 2020. It is now read-only.

Commit e97a0e9

Browse files
committed
Release 5.0.0
1 parent 960823c commit e97a0e9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+676
-116
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# @oracle/generator-oraclejet 4.2.0
1+
# @oracle/generator-oraclejet 5.0.0
22

33
## About the generator
44
This Yeoman generator for Oracle JET lets you quickly set up a project for use as a web application or hybrid mobile application for Android, iOS or Windows 10.

RELEASENOTES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
## Release Notes for generator-oraclejet ##
22

3+
### 5.0.0
4+
* No changes
5+
36
### 4.2.0
47
* No changes
58

common/component.js

Lines changed: 43 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ module.exports =
3737
}
3838
fs.ensureDirSync(destDirectory);
3939
fs.copySync(templateSrc, destDirectory);
40+
41+
_renamePrefix(generator);
4042
_replaceComponentTemplateToken(generator);
4143
}
4244

@@ -46,7 +48,20 @@ module.exports =
4648
};
4749

4850
function _replaceComponentTemplateToken(generator) {
49-
const componentName = generator.componentName || generator.options.component;
51+
const componentName = _getComponentName(generator);
52+
53+
const base = _getBasePath(generator);
54+
55+
fs.readdirSync(base).forEach((file) => {
56+
if (path.extname(file).length !== 0) {
57+
const fileContent = fs.readFileSync(path.join(base, file), 'utf-8');
58+
fs.outputFileSync(path.join(base, file), fileContent.replace(new RegExp('@component@', 'g'), componentName));
59+
}
60+
});
61+
}
62+
63+
function _getBasePath(generator) {
64+
const componentName = _getComponentName(generator);
5065

5166
const appDir = generator.appDir === undefined
5267
? process.cwd() : generator.destinationPath(generator.appDir);
@@ -57,8 +72,32 @@ function _replaceComponentTemplateToken(generator) {
5772
const base = path.join(appDir, _configPaths.source,
5873
_configPaths.sourceJavascript, CONSTANTS.JET_COMPOSITES, componentName);
5974

60-
CONSTANTS.COMPONENT_FILES.forEach((file) => {
61-
const fileContent = fs.readFileSync(path.join(base, file), 'utf-8');
62-
fs.outputFileSync(path.join(base, file), fileContent.replace(new RegExp('@component@', 'g'), componentName));
75+
return base;
76+
}
77+
78+
function _getComponentName(generator) {
79+
return generator.componentName || generator.options.component;
80+
}
81+
82+
function _renamePrefix(generator) {
83+
let base = _getBasePath(generator);
84+
const componentName = _getComponentName(generator);
85+
fs.readdirSync(base).forEach((file) => {
86+
if (/@component@/.test(file)) _renamePrefixFile(generator, base, file, componentName);
6387
});
88+
89+
base = path.join(base, 'resources/nls');
90+
if (fs.existsSync(base)) {
91+
fs.readdirSync(base).forEach((file) => {
92+
if (/@component@/.test(file)) _renamePrefixFile(generator, base, file, componentName);
93+
});
94+
}
95+
}
96+
97+
// replace prefix to include the component name
98+
function _renamePrefixFile(generator, fileDir, file, componentName) {
99+
const oldPath = path.join(fileDir, file);
100+
let newPath = file.replace('@component@', componentName);
101+
newPath = path.join(fileDir, newPath);
102+
fs.renameSync(oldPath, newPath);
64103
}

common/messages.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ module.exports =
2828
};
2929

3030
function _getScaffoldComplete() {
31-
return _appendSuccessPrefix('Your app structure is generated. Continuing with library install...');
31+
return _appendSuccessPrefix('Your app structure is generated. Continuing with library install.');
3232
}
3333

3434
function _getRestoreComplete(invokedByRestore, appDir) {
3535
if (invokedByRestore) {
36-
return _appendSuccessPrefix('Your app restore finished successfully...');
36+
return _appendSuccessPrefix('\x1b[32mYour app restore finished successfully.\x1b[0m');
3737
}
38-
return _appendSuccessPrefix(`Your app is ready! Change to your new app directory ${appDir} and try ojet build and serve...`);
38+
return _appendSuccessPrefix(`\x1b[32mYour app is ready! Change to your new app directory '${appDir}' and try 'ojet build' and 'ojet serve'.\x1b[0m`);
3939
}
4040

4141
function _getPrefixError(error) {
@@ -60,9 +60,9 @@ function _getError(error, task) {
6060
}
6161

6262
function _appendSuccessPrefix(message) {
63-
return `Oracle JET: ${message}`;
63+
return `${message}`;
6464
}
6565

6666
function _appendErrorPrefix(message) {
67-
return `Oracle JET Error: ${message}`;
67+
return `${message}`;
6868
}

common/restore.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,20 @@ module.exports =
2121
const configPath = path.resolve(destinationRoot, ORACLE_JET_CONFIG_FILE);
2222

2323
return new Promise((resolve) => {
24-
generator.log('Writing ', ORACLE_JET_CONFIG_FILE);
24+
generator.log('Writing:', ORACLE_JET_CONFIG_FILE);
2525

2626
// need to place the oracletjetconfig.json at origDestRoot
2727

2828
fs.stat(configPath, (err) => {
2929
const generatorVersion = _getOracleJetGeneratorVersion(generator);
3030
if (err) {
31-
generator.log(`${commonMessages.appendJETPrefix()}No config file...writing the default config...`);
31+
generator.log(`${commonMessages.appendJETPrefix()}No config file. Writing the default config.`);
3232
fs.writeJSONSync(configPath, { generatorVersion });
3333
} else {
3434
const configJson = fs.readJSONSync(configPath);
3535
configJson.generatorVersion = generatorVersion;
3636
fs.writeJSONSync(configPath, configJson);
37-
generator.log(`${commonMessages.appendJETPrefix() + ORACLE_JET_CONFIG_FILE} file exists...checking config...`);
37+
generator.log(`${commonMessages.appendJETPrefix() + ORACLE_JET_CONFIG_FILE} file exists. Checking config.`);
3838
}
3939
resolve(context);
4040
});
@@ -44,7 +44,7 @@ module.exports =
4444
npmInstall: function _npmInstall(context) {
4545
return new Promise((resolve, reject) => {
4646
Promise.all([
47-
common.gruntSpawnCommandPromise(context, 'npm', ['install'], 'Invoking npm install')
47+
common.gruntSpawnCommandPromise(context, 'npm', ['install'], 'Invoking npm install.')
4848
])
4949
.then(() => {
5050
// rejection will be handled by each promise which will

common/template/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const _WEB = 'web';
1717

1818
const BLANK_TEMPLATE = blankTemplate.BLANK_TEMPLATE;
1919

20-
const _TEMPLATES_NPM_URL = '@oracle/oraclejet-templates@~4.2.0';
20+
const _TEMPLATES_NPM_URL = '@oracle/oraclejet-templates@~5.0.0';
2121

2222
const _TEMPLATES = [BLANK_TEMPLATE, 'basic', 'navbar', 'navdrawer'];
2323

@@ -26,7 +26,7 @@ module.exports =
2626
{
2727
handleTemplate: function _handleTemplate(generator, templateDestDirectory) {
2828
const template = generator.options.template || BLANK_TEMPLATE;
29-
generator.log('Processing template...', template);
29+
generator.log('Processing template:', template);
3030
const templateHandler = _getHandler(generator, template, templateDestDirectory);
3131
return commonTemplate.handle(templateHandler);
3232
}

common/test.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,13 @@ module.exports =
3030
path.join(appDir, _configPaths.source, _configPaths.sourceTests));
3131

3232
// avoid overwrite test
33-
if (fs.existsSync(destDirectory)) resolve(generator);
34-
35-
fs.ensureDirSync(destDirectory);
36-
fs.copySync(templateSrc, destDirectory);
37-
_replaceTestHTMLToken(generator);
33+
if (fs.existsSync(destDirectory)) {
34+
resolve(generator);
35+
} else {
36+
fs.ensureDirSync(destDirectory);
37+
fs.copySync(templateSrc, destDirectory);
38+
_replaceTestHTMLToken(generator);
39+
}
3840
}
3941
return resolve(generator);
4042
});

generators/add-component/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@ const OracleJetAddComponentGenerator = generators.Base.extend(
6464
if (!isApp) {
6565
this.composeWith('@oracle/oraclejet:app', { options: this.options });
6666
} else {
67-
console.log(commonMessages.appendJETPrefix(`add component ${this.componentName} finished.`));
67+
console.log(commonMessages.appendJETPrefix(`Add component ${this.componentName} finished.`));
6868
}
69-
if (isApp) process.exit(1);
69+
if (isApp) process.exit(0);
7070
}
7171

7272
});
@@ -77,6 +77,6 @@ function _validateComponentName(generator) {
7777
const name = generator.componentName;
7878
if (name !== name.toLowerCase() || name.indexOf('-') < 0 || !/^[a-z]/.test(name)) {
7979
const message = 'Invalid component name. Must be all lowercase letters and contain at least one hyphen.';
80-
throw `\x1b[31m${new Error(message)}\x1b[0m`; //eslint-disable-line
80+
generator.env.error(`\x1b[31m${new Error(message)}\x1b[0m`); //eslint-disable-line
8181
}
8282
}

generators/add-sass/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const OracleJetAddSassGenerator = generators.Base.extend(
4545

4646
end: function() { //eslint-disable-line
4747
console.log(commonMessages.appendJETPrefix('add-sass finished.'));
48-
process.exit(1);
48+
process.exit(0);
4949
}
5050

5151
});
@@ -55,7 +55,7 @@ module.exports = OracleJetAddSassGenerator;
5555

5656
function _npmInstallNodeSass(generator) {
5757
try {
58-
generator.npmInstall(['node-sass@4.5.3'], { saveDev: true });
58+
generator.npmInstall(['node-sass@4.7.2'], { saveDev: true });
5959
return Promise.resolve(generator);
6060
} catch (err) {
6161
return Promise.reject(commonMessages.error(err, 'install node-sass'));

generators/add-theme/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const OracleJetAddThemeGenerator = generators.Base.extend(
6464

6565
end: function () { //eslint-disable-line
6666
this.log(commonMessages.appendJETPrefix(`${this.themeName} theme added.`));
67-
process.exit(1);
67+
process.exit(0);
6868
}
6969

7070
});

0 commit comments

Comments
 (0)