From c52e277b6da540590bf8b6c1c1adf3f62e48b7b4 Mon Sep 17 00:00:00 2001 From: Dominik Dosoudil Date: Wed, 29 May 2024 11:18:20 +0200 Subject: [PATCH 1/2] chore: add .idea to .gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index af3a1757d..4c6a1c291 100644 --- a/.gitignore +++ b/.gitignore @@ -11,3 +11,4 @@ test/spec/api/*.js test/spec/core/*.js test/spec/platform/web/*.js test/support/**/*.js +.idea/ From 6d9c199d7d962e571fb35b9c913553d58fd56721 Mon Sep 17 00:00:00 2001 From: Dominik Dosoudil Date: Wed, 29 May 2024 11:19:01 +0200 Subject: [PATCH 2/2] refactor: remove SDH cast as the iceGatheringComplete is already public --- src/platform/web/session-manager/session-manager.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/platform/web/session-manager/session-manager.ts b/src/platform/web/session-manager/session-manager.ts index 24a21a317..8ea8f7eb8 100644 --- a/src/platform/web/session-manager/session-manager.ts +++ b/src/platform/web/session-manager/session-manager.ts @@ -574,11 +574,7 @@ export class SessionManager { onicecandidate: (event) => { if (event.candidate?.type === "srflx") { this.logger.log(`[${inviter.id}] Found srflx ICE candidate, stop waiting...`); - // In sip.js > 0.20.1 this cast should be removed as iceGatheringComplete will be public - const sdh = sessionDescriptionHandler as SessionDescriptionHandler & { - iceGatheringComplete: () => void; - }; - sdh.iceGatheringComplete(); + sessionDescriptionHandler.iceGatheringComplete(); } } };