WIP: Transition to Eio #12
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This done automatically thanks to https://github.com/Julow/lwt-to-direct-style The `lwt.unix` dependency is added because it previously was a transitive dependency through lwt_log.
`ignore x` and `let _ = x` create an implicit fork if `x` is an `Lwt.t` value. This annotate all "ignored" values and change two implicit forks into explicit calls `Lwt.async`.
This creates a testsuite by writing the first test. The test makes sure that the `Ref.get` and `Ref.set` functions work with the sqlite backend.
Update Dune and Opam files. Ref: Use a lazy instead of a promise. Thread.yield -> Fiber.yield. Add `current_switch` fiber key. Tweaks. Query 'env' from Ocsigen_lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #9 #10 #11
Depends on ocsigenserver with this patch: ocsigen/ocsigenserver#269
TODO:
ocsipersistto eioocsipersist-libto eioocsipersist-sqliteto eioocsipersist-dbmto eioocsipersist-pgsqlto eioThe first commit "Automatic changes done with lwt-to-direct-style" contains the change done automatically with https://github.com/Julow/lwt-to-direct-style/
The second commit, "Manual changes", contains all the manual changes that I had to do to transition the codebase to Eio. It's all squashed into one commit to make rebasing easier. Will be broken down into several commits when the work is done.