forked from kenn/redis-mutex
-
Notifications
You must be signed in to change notification settings - Fork 0
Add new mutex strategies #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jwoodrow
wants to merge
20
commits into
master
Choose a base branch
from
alternative_mutex_strategies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+569
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sider supporting ruby 3+ only ?)
…gging also remove rake dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new strategies to RedisMutex
concurrent
: Prevent concurrent executions of the block provided, once the block ends, release of the mutex "lock" juste like "standard"cumulative
: Prevent a block from being executed too many times over a slidingperiod of time (sliding window looking backexpire
seconds)windowed
: Prevent a block from being executed too many times over a fixed period of time (at the end ofexpire seconds
the execution counter would get reset to 0Try to make everything backwards compatible by making concurrent strategy and limit 1 the default for the 2 new options introduced
limit
: How many concurrent block executions do you want to limit yourself to (default 1)type
: The type of mutex strategy you wish to use (default concurrent [cumulative, windowed])Also for easier contribution:
Still need to add some concurrent/cumulative/windowed specific specs but this currently makes it so the specs work without the need to update them
Here are some simple testing scripts to see how each of these strategies work (adding them as I go)
concurrent + limit > 1