Merge pull request #5 from urialon/fix_finalise

Removing argument 'is_train' which is not used in SeqDecoder.finalise_minibatch

Author: mmjb

Models/exprsynth/seq2seqmodel.py

@@ -83,7 +83,7 @@ def _extend_minibatch_by_sample(self, batch_data: Dict[str, Any], sample: Dict[s
 
     def _finalise_minibatch(self, batch_data: Dict[str, Any], is_train: bool) -> Dict[tf.Tensor, Any]:
         minibatch = super()._finalise_minibatch(batch_data, is_train)
-        self._decoder_model.finalise_minibatch(batch_data, minibatch, is_train)
+        self._decoder_model.finalise_minibatch(batch_data, minibatch)
         return minibatch
 
     # ------- These are the bits that we only need for test-time:

Models/exprsynth/seqdecoder.py

@@ -290,7 +290,7 @@ def extend_minibatch_by_sample(self, batch_data: Dict[str, Any], sample: Dict[st
         batch_data['target_token_ids'].append(sample['target_token_ids'])
         batch_data['target_token_ids_mask'].append(sample['target_token_ids_mask'])
 
-    def finalise_minibatch(self, batch_data: Dict[str, Any], minibatch: Dict[tf.Tensor, Any], is_train: bool) -> None:
+    def finalise_minibatch(self, batch_data: Dict[str, Any], minibatch: Dict[tf.Tensor, Any]) -> None:
         write_to_minibatch(minibatch, self.placeholders['target_token_ids'], batch_data['target_token_ids'])
         write_to_minibatch(minibatch, self.placeholders['target_token_ids_mask'], batch_data['target_token_ids_mask'])