From 685ffa218b506f6a3d1f3afd8ae87ee4b857b13e Mon Sep 17 00:00:00 2001 From: Sideways S Date: Sat, 3 Feb 2024 12:53:06 -0600 Subject: [PATCH 1/2] await unnecessary, errors should be handled --- service-worker/simple-service-worker/sw.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/service-worker/simple-service-worker/sw.js b/service-worker/simple-service-worker/sw.js index 0d4fae58..b52e13ae 100644 --- a/service-worker/simple-service-worker/sw.js +++ b/service-worker/simple-service-worker/sw.js @@ -1,11 +1,11 @@ const addResourcesToCache = async (resources) => { const cache = await caches.open('v1'); - await cache.addAll(resources); + cache.addAll(resources).catch(err => console.error(err, err.stack)); }; const putInCache = async (request, response) => { const cache = await caches.open('v1'); - await cache.put(request, response); + cache.put(request, response).catch(err => console.error(err, err.stack)); }; const cacheFirst = async ({ request, preloadResponsePromise, fallbackUrl }) => { From aab53f975a9674710b6747fc9c2d0f28032bc026 Mon Sep 17 00:00:00 2001 From: Sideways S Date: Thu, 15 Feb 2024 08:17:48 -0600 Subject: [PATCH 2/2] err.stack includes err.toString() --- service-worker/simple-service-worker/sw.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/service-worker/simple-service-worker/sw.js b/service-worker/simple-service-worker/sw.js index b52e13ae..8f347663 100644 --- a/service-worker/simple-service-worker/sw.js +++ b/service-worker/simple-service-worker/sw.js @@ -1,11 +1,11 @@ const addResourcesToCache = async (resources) => { const cache = await caches.open('v1'); - cache.addAll(resources).catch(err => console.error(err, err.stack)); + cache.addAll(resources).catch(err => console.error(err.stack ?? err)); }; const putInCache = async (request, response) => { const cache = await caches.open('v1'); - cache.put(request, response).catch(err => console.error(err, err.stack)); + cache.put(request, response).catch(err => console.error(err.stack ?? err)); }; const cacheFirst = async ({ request, preloadResponsePromise, fallbackUrl }) => {