Updates ingress definition with ingressClassName field #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
reviewed
Jul 2, 2025
Comment on lines
+24
to
+25
| {{- if .Values.ingress.className }} | ||
| ingressClassName: {{ .Values.ingress.className }} |
There was a problem hiding this comment.
Suggested change
| {{- if .Values.ingress.className }} | |
| ingressClassName: {{ .Values.ingress.className }} | |
| {{- with .Values.ingress.className }} | |
| ingressClassName: {{ . }} |
Just a minor style point- this avoids some repetition
| @@ -66,9 +66,10 @@ service: | |||
| enabled: true | |||
| clientTimeout: 3600 | |||
|
|
|||
| # Only used for omero websockets | |||
| # Only used for omero websockets (wegsockets needs to be activated) | |||
There was a problem hiding this comment.
Suggested change
| # Only used for omero websockets (wegsockets needs to be activated) | |
| # Only used for omero websockets (not activated by default) |
Comment on lines
+19
to
+20
| {{- if .Values.ingress.className }} | ||
| ingressClassName: {{ .Values.ingress.className }} |
There was a problem hiding this comment.
Suggested change
| {{- if .Values.ingress.className }} | |
| ingressClassName: {{ .Values.ingress.className }} | |
| {{- with .Values.ingress.className }} | |
| ingressClassName: {{ . }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of stating a name of a IngressClass in a field "ingressClassName".
Why?
I am getting the following warning when I deploy the ingresses with the annotation instead of the dedicated field from the spec
W1129 12:41:17.534196 143471 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead
See also https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation