Fix for 'Integrity constraint violation: 1062 Duplicate entry '11-general' for key' #929
+47
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves the way custom groups are migrated from Magento 1 to Magento 2.
Does away with the previous method of trying to find the default, non-product group logic which attempted to use the initialData to see what were the defaults.
The problem was that it did not take into account the remapping of entity types and attribute sets and so was looking up Magento 1 groups on Magento 2 by attributeSetId which would have been changed.
This leads to it bugging and thinking some default groups need to be added as "custom groups" but this clashes with previous migration work that already remapped groups.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist