[clang-tidy] "readability-container-data-pointer" - should not warn in non-const pointers usage before C++17

[denzor200]

Assume for this example:

std::string a = "test", b = "eest";
std::memcpy(&a[0], &b[0], a.size());

The check will produce wrong code for C++11 and C++14, but correct for C++17 and newer:

std::string a = "test", b = "eest";
std::memcpy(a.data(), b.data(), a.size());  // error: cannot initialize a parameter of type 'void *' with an rvalue of type 'const char *' 

I expect this check to remain for C++17 as it is, but for older will produce this code:

std::string a = "test", b = "eest";
std::memcpy(&a[0], b.data(), a.size());

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Denis Mikhailov (denzor200)

Assume for this example: ``` std::string a = "test", b = "eest"; std::memcpy(&a[0], &b[0], a.size()); ```

The check will produce wrong code for C++11 and C++14, but correct for C++17 and newer:

std::string a = "test", b = "eest";
std::memcpy(a.data(), b.data(), a.size());  // error: cannot initialize a parameter of type 'void *' with an rvalue of type 'const char *' 

I expect this check to remain for C++17 as it is, but for older will produce this code:

std::string a = "test", b = "eest";
std::memcpy(&a[0], b.data(), a.size());

[denzor200]

This issue actual for at least std::string. With std::vector no such problem at all