Comma ignored on PR title check

[GFriedrich]

Following the guide of https://docs.gitstream.cm/automations/standard/enforce-pr-title/ and trying to add a comma to the regex like

r/\b(build|ci|docs|feature|fix)\b\s*\((common|core|elements|forms|http)\):\s*[\w\s,]+/

causes the check still to fail if the title is containing a comma.
What am I doing wrong here or is this a bug?
Thanks in advance for any help.

[PavelLinearB]

Hi @GFriedrich, thanks for raising this issue.
I've tried to recreate it on my repository, but it looks like the automation is working correctly:
Here is the example PR: PavelLinearB/gitStream-tests#97
When I named it build(core): this, is a test, the automation didn't do anything (since the regex was found)
When I changed it to build(core) this, is a test, the regex was not found, and the automation was executed.

Can you please share an example of a name that failed in your case?
Thanks,
Pavel.

[vim-zz]

Can you provide here a list of titles you expect to be valid that you now see you get unwanted match? It will help us with making sure the solution works properly

[GFriedrich]

That's great to hear.
So that's a rough list of titles:

• feat: this is a commit ABC-123
• feat(module): this is a commit ABC-123
• feat(better-module): this is a commit ABC-123
• feat(module-a module-b): this is a commit ABC-123
• feat(module-a module-b): this is a complex commit; with added detail, more comment/info and such-a-thing ABC-123

[vim-zz]

we have rolled back the change from yesterday night, and looking into a better fix

[vim-zz]

Hey, please switch the match with includes. match expects a list of but the title is not a list, you should use includes as follows

- {{ (pr.title | includes(regex=titlePolicy.titleRegex)) == false }}

this replaces the current {{ pr.title | match(regex=titlePolicy.titleRegex) | nope }} ← should be replaced with the above snippet!

[GFriedrich]

@vim-zz: Thanks so much. Things are now working as expected together with the latest GitHub action. 🙏