Fix bug where DiscordRPC wouldn't start or would be stuck in "Main Menu" and attempt to reconnect to discord (#213)

* I think this fixes DiscordRPC?

* Attempt to reconnect DiscordRPC when discord is reopened

Author: Nep Nep

src/main/kotlin/com/lambda/client/module/modules/misc/DiscordRPC.kt

@@ -77,14 +77,14 @@ object DiscordRPC : Module(
     }
 
     private fun start() {
-        BackgroundScope.launchLooping(job)
-
         LambdaMod.LOG.info("Starting Discord RPC")
+
         try {
             ipc.connect()
             rpcBuilder.setStartTimestamp(OffsetDateTime.now())
             val richPresence = rpcBuilder.build()
             ipc.sendRichPresence(richPresence)
+            BackgroundScope.launchLooping(job)
 
             LambdaMod.LOG.info("Discord RPC initialised successfully")
         } catch (e: NoDiscordClientException) {
@@ -94,11 +94,11 @@ object DiscordRPC : Module(
     }
 
     private fun end() {
-        if (!initialised || ipc.status != PipeStatus.CONNECTED) return
-        BackgroundScope.cancel(job)
-
         LambdaMod.LOG.info("Shutting down Discord RPC...")
-        ipc.close()
+        BackgroundScope.cancel(job)
+        if (initialised && ipc.status == PipeStatus.CONNECTED) {
+            ipc.close()
+        }
     }
 
     private fun showCoordsConfirm(): Boolean {
@@ -109,12 +109,34 @@ object DiscordRPC : Module(
     }
 
     private fun updateRPC() {
-        if (ipc.status == PipeStatus.CONNECTED) {
-            val richPresence = rpcBuilder
-                .setDetails(getLine(line1Left) + getSeparator(0) + getLine(line1Right))
-                .setState(getLine(line2Left) + getSeparator(1) + getLine(line2Right))
-                .build()
-            ipc.sendRichPresence(richPresence)
+        when (ipc.status) {
+            PipeStatus.CONNECTED -> {
+                val richPresence = rpcBuilder
+                    .setDetails(getLine(line1Left) + getSeparator(0) + getLine(line1Right))
+                    .setState(getLine(line2Left) + getSeparator(1) + getLine(line2Right))
+                    .build()
+                ipc.sendRichPresence(richPresence)
+            }
+
+            PipeStatus.UNINITIALIZED -> {
+                tryConnect()
+            }
+
+            PipeStatus.DISCONNECTED -> {
+                tryConnect()
+            }
+
+            else -> {
+                // Why is this necessary now kotlin? WHY
+            }
+        }
+    }
+
+    private fun tryConnect() {
+        try {
+            ipc.connect()
+        } catch (e: NoDiscordClientException) {
+            // Add something here if you want to spam the log i guess
         }
     }
 
@@ -187,10 +209,11 @@ object DiscordRPC : Module(
     }
 
     fun setCustomIcons(capeType: CapeType?) {
+        // The nullability here is VERY important, DO NOT switch this for an empty string, it causes discord to break
         val text = when (capeType) {
             CapeType.CONTRIBUTOR -> "Contributor"
-            else -> ""
+            else -> null
         }
-        rpcBuilder.setSmallImage(capeType?.imageKey ?: "", text)
+        rpcBuilder.setSmallImage(capeType?.imageKey, text)
     }
 }