From 8ce82d2a89402d3259881045e900e339027c475a Mon Sep 17 00:00:00 2001 From: Simone Tollardo Date: Tue, 10 Jun 2025 10:20:19 +0200 Subject: [PATCH 1/2] Add LAVA runtime job definition getter method Signed-off-by: Simone Tollardo --- kernelci/runtime/lava.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernelci/runtime/lava.py b/kernelci/runtime/lava.py index e2df704129..04b693da33 100644 --- a/kernelci/runtime/lava.py +++ b/kernelci/runtime/lava.py @@ -96,6 +96,10 @@ def get_device_id(self): """Get the ID of the tested device""" return self._data.get('actual_device_id') + def get_job_definition(self, key): + """Get the job definition""" + return yaml.safe_load(self._data.get('definition')).get(key) + def get_meta(self, key): """Get a metadata value from the job definition""" if self._meta is None: From a8a71567a5319aaf8b29a3552413fa3fa2f4bc1e Mon Sep 17 00:00:00 2001 From: Simone Tollardo Date: Tue, 10 Jun 2025 10:23:47 +0200 Subject: [PATCH 2/2] Refactor: remove unnecessary '_meta' instance var from 'Callback' class Signed-off-by: Simone Tollardo --- kernelci/runtime/lava.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernelci/runtime/lava.py b/kernelci/runtime/lava.py index 04b693da33..9f9abd1795 100644 --- a/kernelci/runtime/lava.py +++ b/kernelci/runtime/lava.py @@ -86,7 +86,6 @@ class Callback: def __init__(self, data): """This class can be used to parse LAVA callback data""" self._data = data - self._meta = None def get_data(self): """Get the raw callback data""" @@ -102,9 +101,7 @@ def get_job_definition(self, key): def get_meta(self, key): """Get a metadata value from the job definition""" - if self._meta is None: - self._meta = yaml.safe_load(self._data['definition'])['metadata'] - return self._meta.get(key) + return self.get_job_definition('metadata').get(key) def get_job_status(self): """Get the job status"""