Fixes #6971,bz1085417 - api handle nonexistent id

In capsule and product APIs, the show action for a nonexistant id fails
to give a proper 404.

for example /api/products/123123 where product 123132 does not exist
product gives 500 no resource loaded

capsule gives protected method `resource_name' called for

Author: Dustin Tsang

app/controllers/katello/api/v2/capsules_controller.rb

@@ -29,16 +29,16 @@ def show
       super
     end
 
+    def resource_name
+      :smart_proxy
+    end
+
     protected
 
     def resource_class
       SmartProxy
     end
 
-    def resource_name
-      :smart_proxy
-    end
-
     def authorized
       User.current.allowed_to?(params.slice(:action, :id).merge(controller: 'api/v2/smart_proxies'))
     end

app/controllers/katello/api/v2/products_controller.rb

@@ -109,7 +109,8 @@ def sync
     protected
 
     def find_product
-      @product = Product.find_by_id(params[:id]) if params[:id]
+      @product = Product.find_by_id(params[:id])
+      fail HttpErrors::NotFound, _("Couldn't find product '%s'") % params[:id] unless @product
     end
 
     def find_activation_key