Fixed #13

Rafael Grigorian · Rafael Grigorian · commit d661a7dabc4e · 2020-06-12T12:30:02.000-05:00
diff --git a/src/app/code/community/JetRails/TwoFactor/Helper/Totp.php b/src/app/code/community/JetRails/TwoFactor/Helper/Totp.php
@@ -99,7 +99,7 @@ private function secret ( $length = 16 ) {
 			// Traverse $length times, to get random base32 encoding
 			for ( $i = 0; $i < $length; $i++ ) {
 				// Append a random number from base32 alphabet
-				$secret .= $this->alphabet [ mt_rand ( 0, strlen ( $this->alphabet ) - 1 ) ];
+				$secret .= $this->alphabet [ random_int ( 0, strlen ( $this->alphabet ) - 1 ) ];
 			}
 			// Return the resulting secret
 			return $secret;

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ private function secret ( $length = 16 ) {`
`99`	`99`	`// Traverse $length times, to get random base32 encoding`
`100`	`100`	`for ( $i = 0; $i < $length; $i++ ) {`
`101`	`101`	`// Append a random number from base32 alphabet`
`102`		`- $secret .= $this->alphabet [ mt_rand ( 0, strlen ( $this->alphabet ) - 1 ) ];`
	`102`	`+ $secret .= $this->alphabet [ random_int ( 0, strlen ( $this->alphabet ) - 1 ) ];`
`103`	`103`	`}`
`104`	`104`	`// Return the resulting secret`
`105`	`105`	`return $secret;`