Merge branch 'develop'

Author: znorman-harris

CHANGELOG.md

@@ -46,6 +46,14 @@ Code style revamp! We reworked how routines, routine methods, properties, and st
 
 - When generating ENVI and IDL tasks, using our new case libraries, we attempt to make a pretty display name from parameter names. For example converting the keyword "my_keyword" to "My Keyword". This applied to task and parameter display names.
 
+## 4.2.2 December 2023
+
+Resolved a performance issue with notebooks where auto-complete and hover help would take a while to return if you have been making many edits in a short amount of time
+
+Fixed an issue with semantic tokens not showing up like they should.
+
+Tweaked the styling for PDF generation to have output cells look a little different than input.
+
 ## 4.2.1 December 2023
 
 Fixed an issue where logs were sharing too much information and other logs were not properly reporting

apps/client-e2e/src/tests/debugging/breakpoint-step-in-step-out.ts

@@ -77,13 +77,4 @@ export const BreakPointStepInStepOut: RunnerFunction = async (init) => {
 
   // reset
   await init.debug.adapter.evaluate('.reset');
-
-  // close editor
-  await vscode.commands.executeCommand(VSCODE_COMMANDS.CLOSE_EDITOR);
-
-  // pause momentarily
-  await Sleep(DEBUG_PAUSE);
-
-  // verify we cleaned up
-  expect(GetActivePROCodeWindow(false)).toBeUndefined();
 };

apps/client-e2e/src/tests/debugging/compile.ts

@@ -1,7 +1,7 @@
 import { CleanIDLOutput } from '@idl/idl';
 import { IDL_COMMANDS } from '@idl/shared';
 import { Sleep } from '@idl/test-helpers';
-import { GetActivePROCodeWindow, VSCODE_COMMANDS } from '@idl/vscode/shared';
+import { GetActivePROCodeWindow } from '@idl/vscode/shared';
 import expect from 'expect';
 import * as vscode from 'vscode';
 
@@ -42,13 +42,4 @@ export const Compile: RunnerFunction = async (init) => {
 
   // make sure it is the plot file
   expect(editor.uri.fsPath.endsWith('plot.pro')).toBeTruthy();
-
-  // close editor
-  await vscode.commands.executeCommand(VSCODE_COMMANDS.CLOSE_EDITOR);
-
-  // pause momentarily
-  await Sleep(DEBUG_PAUSE);
-
-  // verify we cleaned up
-  expect(GetActivePROCodeWindow(false)).toBeUndefined();
 };

apps/client-e2e/src/tests/debugging/continue.ts

@@ -72,13 +72,4 @@ export const Continue: RunnerFunction = async (init) => {
     // wait a little bit
     await Sleep(DEBUG_PAUSE);
   }
-
-  // close editor
-  await vscode.commands.executeCommand(VSCODE_COMMANDS.CLOSE_EDITOR);
-
-  // pause momentarily
-  await Sleep(DEBUG_PAUSE);
-
-  // verify we cleaned up
-  expect(GetActivePROCodeWindow(false)).toBeUndefined();
 };

apps/client-e2e/src/tests/debugging/edit.ts

@@ -1,6 +1,6 @@
 import { IDL_COMMANDS } from '@idl/shared';
 import { Sleep } from '@idl/test-helpers';
-import { GetActivePROCodeWindow, VSCODE_COMMANDS } from '@idl/vscode/shared';
+import { GetActivePROCodeWindow } from '@idl/vscode/shared';
 import expect from 'expect';
 import * as vscode from 'vscode';
 
@@ -36,13 +36,4 @@ export const Edit: RunnerFunction = async (init) => {
 
   // make sure it is the plot file
   expect(editor.uri.fsPath.endsWith('plot.pro')).toBeTruthy();
-
-  // close editor
-  await vscode.commands.executeCommand(VSCODE_COMMANDS.CLOSE_EDITOR);
-
-  // pause momentarily
-  await Sleep(DEBUG_PAUSE);
-
-  // verify we cleaned up
-  expect(GetActivePROCodeWindow(false)).toBeUndefined();
 };

apps/client-e2e/src/tests/interactions/_interactions-runner.ts

@@ -4,9 +4,10 @@ import { Runner } from '../runner.class';
 import { AddDocs } from './add-docs';
 import { IDLJSONInteractRight } from './idl-json-interact-right';
 import { IndexIDLFolderRightAndOpenEditClose } from './index-idl-folder-right-and-open-edit-close';
+import { NotebookProblemsTrackRight } from './notebook-problems-track-right';
 import { NotebookCompletionBasic } from './notebooks-completion-basic';
 import { NotebooksInteractRight } from './notebooks-interact-right';
-import { NotebooksNoDuplicates } from './notebooks-no-duplicates';
+import { NotebooksNoDuplicateRoutines } from './notebooks-no-duplicate-routines';
 import { ProCodeInteractRight } from './pro-code-interacts-right';
 import { TasksInteractRight } from './tasks-interact-right';
 
@@ -56,12 +57,18 @@ INTERACTIONS_RUNNER.addTest({
 });
 
 INTERACTIONS_RUNNER.addTest({
-  name: 'Notebook problems track right',
-  fn: NotebooksNoDuplicates,
+  name: 'No duplicate routine definition problems',
+  fn: NotebooksNoDuplicateRoutines,
 });
 
 INTERACTIONS_RUNNER.addTest({
   name: 'Verify notebook auto-complete passes basic tests',
   fn: NotebookCompletionBasic,
   critical: true,
 });
+
+// notebook problems track right
+INTERACTIONS_RUNNER.addTest({
+  name: 'Notebook problems track right',
+  fn: NotebookProblemsTrackRight,
+});

apps/client-e2e/src/tests/interactions/add-docs.ts

@@ -1,9 +1,5 @@
 import { GetExtensionPath, IDL_COMMANDS, Sleep } from '@idl/shared';
-import {
-  OpenFileInVSCode,
-  ReplaceDocumentContent,
-  VSCODE_COMMANDS,
-} from '@idl/vscode/shared';
+import { OpenFileInVSCode, ReplaceDocumentContent } from '@idl/vscode/shared';
 import expect from 'expect';
 import { readFileSync } from 'fs';
 import * as vscode from 'vscode';
@@ -60,7 +56,4 @@ export const AddDocs: RunnerFunction = async (init) => {
       'utf-8'
     )
   );
-
-  // clear any existing outputs
-  await vscode.commands.executeCommand(VSCODE_COMMANDS.CLOSE_EDITOR);
 };

apps/client-e2e/src/tests/interactions/idl-json-interact-right.ts

@@ -1,9 +1,5 @@
 import { GetExtensionPath, Sleep } from '@idl/shared';
-import {
-  OpenFileInVSCode,
-  ReplaceDocumentContent,
-  VSCODE_COMMANDS,
-} from '@idl/vscode/shared';
+import { OpenFileInVSCode, ReplaceDocumentContent } from '@idl/vscode/shared';
 import expect from 'expect';
 import { readFileSync } from 'fs';
 import * as vscode from 'vscode';
@@ -76,10 +72,4 @@ export const IDLJSONInteractRight: RunnerFunction = async (init) => {
     'textDocument/semanticTokens/full',
     tokenParams
   );
-
-  // short pause
-  await Sleep(250);
-
-  // clear any existing outputs
-  await vscode.commands.executeCommand(VSCODE_COMMANDS.CLOSE_EDITOR);
 };

apps/client-e2e/src/tests/notebooks/notebook-problems-track-right.ts renamed to apps/client-e2e/src/tests/interactions/notebook-problems-track-right.ts

@@ -1,5 +1,5 @@
 import { GetExtensionPath, Sleep } from '@idl/shared';
-import { OpenNotebookInVSCode, VSCODE_COMMANDS } from '@idl/vscode/shared';
+import { OpenNotebookInVSCode } from '@idl/vscode/shared';
 import expect from 'expect';
 import * as vscode from 'vscode';
 
@@ -47,7 +47,4 @@ export const NotebookProblemsTrackRight: RunnerFunction = async (init) => {
       .getCells()
       .map((cell) => vscode.languages.getDiagnostics(cell.document.uri).length)
   ).toEqual([0, 3]);
-
-  // clear any existing outputs
-  await vscode.commands.executeCommand(VSCODE_COMMANDS.CLOSE_EDITOR);
 };

apps/client-e2e/src/tests/interactions/notebooks-completion-basic.ts

@@ -1,7 +1,6 @@
 import { GetExtensionPath, Sleep } from '@idl/shared';
-import { OpenNotebookInVSCode, VSCODE_COMMANDS } from '@idl/vscode/shared';
+import { OpenNotebookInVSCode } from '@idl/vscode/shared';
 import expect from 'expect';
-import * as vscode from 'vscode';
 import {
   CompletionItem as LanguageServerCompletionItem,
   TextDocumentPositionParams,
@@ -67,7 +66,4 @@ export const NotebookCompletionBasic: RunnerFunction = async (init) => {
   // verify definition has return
   expect(completion2).toStrictEqual(expect.any(Array));
   expect(completion2.length).not.toEqual(0);
-
-  // clear any existing outputs
-  await vscode.commands.executeCommand(VSCODE_COMMANDS.CLOSE_EDITOR);
 };