Skip to content

Commit 883b7be

Browse files
committed
Handle invalid signature case properly
1 parent 5466ac9 commit 883b7be

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

unittest/src/main/java/score/impl/Crypto.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,9 @@ public static byte[] aggregate(String type, byte[] prevAgg, byte[] values) {
124124
private static byte[] recoverECDSAKey(byte[] msgHash, byte[] signature, boolean compressed) {
125125
BigInteger r = BigIntegers.fromUnsignedByteArray(signature, 0, 32);
126126
BigInteger s = BigIntegers.fromUnsignedByteArray(signature, 32, 32);
127-
return recoverFromSignature(signature[64], r, s, msgHash, compressed);
127+
var k = recoverFromSignature(signature[64], r, s, msgHash, compressed);
128+
require(k != null, "invalid signature");
129+
return k;
128130
}
129131

130132
public static byte[] getAddressBytesFromKey(byte[] pubKey) {

0 commit comments

Comments
 (0)