Skip to content

Proposition to integrate HERMES_VERSION define in ServiceDescription message and SupervisoryServiceDescription message #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/include/Hermes.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ limitations under the License.
# define HERMESPROTOCOL_API
#endif //_WINDOWS

#define HERMES_VERSION "1.0"
#define HERMES_VERSION "1.6"

#include "HermesData.h"

Expand Down
4 changes: 2 additions & 2 deletions src/include/HermesData.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ struct ServiceDescriptionData
std::string m_machineId;
unsigned m_laneId{0};
Optional<std::string> m_optionalInterfaceId;
std::string m_version{"1.5"};
std::string m_version{HERMES_VERSION};
SupportedFeatures m_supportedFeatures;

ServiceDescriptionData() = default;
Expand Down Expand Up @@ -1318,7 +1318,7 @@ struct SupervisoryFeatures
struct SupervisoryServiceDescriptionData
{
std::string m_systemId;
std::string m_version{"1.5"};
std::string m_version{HERMES_VERSION};
SupervisoryFeatures m_supportedFeatures;

SupervisoryServiceDescriptionData() = default;
Expand Down
2 changes: 1 addition & 1 deletion test/BoostTestHermes/CApiTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ namespace
};


std::string sHermesVersion = "1.0";
std::string sHermesVersion = HERMES_VERSION;
std::string sLocalHost = "localhost";
Mutex sTraceMutex;
const unsigned cCHECK_ALIVE_PERIOD = 60U;
Expand Down