Merge pull request #1553 from adumesny/develop

adumesny · web-flow · commit efcda596b92e · 2021-01-02T18:52:43.000-08:00
rev 3.1.3
diff --git a/doc/CHANGES.md b/doc/CHANGES.md
@@ -5,7 +5,7 @@ Change log
 <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
 **Table of Contents**  *generated with [DocToc](http://doctoc.herokuapp.com/)*
 
-- [3.1.2-dev](#312-dev)
+- [3.1.3](#313)
 - [3.1.2 (2020-12-7)](#312-2020-12-7)
 - [3.1.0 (2020-12-4)](#310-2020-12-4)
 - [3.0.0 (2020-11-29)](#300-2020-11-29)
@@ -43,12 +43,13 @@ Change log
 - [v0.1.0 (2014-11-18)](#v010-2014-11-18)
 
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
-## 3.1.2-dev
+## 3.1.3
 
 - fix [1535](https://github.com/gridstack/gridstack.js/issues/1535) use batchUpdate() around grid init to make sure gs-y attributes are respected.
 - fix [1540](https://github.com/gridstack/gridstack.js/issues/1540) Safari H5 drag&drop fixed
 - fix [1545](https://github.com/gridstack/gridstack.js/issues/1545) `disableMove()` correctly prevents drag later (remove events and draggable attribute)
 - fix [1546](https://github.com/gridstack/gridstack.js/issues/1546) resize no longer delayed, which caused race conditions errors
+- fix [1001](https://github.com/gridstack/gridstack.js/issues/1001) resizing near bottom/top needs to auto-scroll/. thanks [@hbcarlos](https://github.com/hbcarlos)!
 
 ## 3.1.2 (2020-12-7)
 
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "gridstack",
-  "version": "3.1.2-dev",
+  "version": "3.1.3",
   "description": "TypeScript/Javascript lib for dashboard layout and creation, no external dependencies, with many wrappers (React, Angular, Ember, knockout...)",
   "main": "./dist/gridstack.js",
   "types": "./dist/gridstack.d.ts",
diff --git a/spec/utils-spec.ts b/spec/utils-spec.ts
@@ -123,7 +123,7 @@ describe('gridstack utils', function() {
       expect(el.style.position).toEqual('');
 
       // bogus test
-      expect(Utils.getScrollParent(el)).toEqual(null);
+      expect(Utils.getScrollParent(el)).not.toBe(null);
       // bogus test
       Utils.updateScrollPosition(el, {top: 20}, 10);
     });
diff --git a/src/gridstack-dd.ts b/src/gridstack-dd.ts
@@ -1,4 +1,4 @@
-// gridstack-GridStackDD.get().ts 3.1.2-dev @preserve
+// gridstack-GridStackDD.get().ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/gridstack-ddi.ts b/src/gridstack-ddi.ts
@@ -1,4 +1,4 @@
-// gridstack-ddi.ts 3.1.2-dev @preserve
+// gridstack-ddi.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/gridstack-engine.ts b/src/gridstack-engine.ts
@@ -1,4 +1,4 @@
-// gridstack-engine.ts 3.1.2-dev @preserve
+// gridstack-engine.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/gridstack-extra.scss b/src/gridstack-extra.scss
@@ -1,5 +1,5 @@
 /*!
- * gridstack 3.1.2-dev extra CSS for [2-11] columns (non default)
+ * gridstack 3.1.3 extra CSS for [2-11] columns (non default)
  * https://gridstackjs.com/
  * (c) 2014-2020  Alain Dumesny, Dylan Weiss, Pavel Reznikov
  * gridstack.js may be freely distributed under the MIT license.
diff --git a/src/gridstack.scss b/src/gridstack.scss
@@ -1,5 +1,5 @@
 /*!
- * gridstack 3.1.2-dev required CSS for default 12 and 1 column Mode size. Use gridstack-extra.css for column [2-11], else see https://github.com/gridstack/gridstack.js#custom-columns-css
+ * gridstack 3.1.3 required CSS for default 12 and 1 column Mode size. Use gridstack-extra.css for column [2-11], else see https://github.com/gridstack/gridstack.js#custom-columns-css
  * https://gridstackjs.com/
  * (c) 2014-2020 Alain Dumesny, Dylan Weiss, Pavel Reznikov
  * gridstack.js may be freely distributed under the MIT license.
diff --git a/src/gridstack.ts b/src/gridstack.ts
@@ -1,4 +1,4 @@
-// gridstack.ts 3.1.2-dev @preserve
+// gridstack.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/h5/dd-base-impl.ts b/src/h5/dd-base-impl.ts
@@ -1,4 +1,4 @@
-// dd-base-impl.ts 3.1.2-dev @preserve
+// dd-base-impl.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/h5/dd-draggable.ts b/src/h5/dd-draggable.ts
@@ -1,4 +1,4 @@
-// dd-draggable.ts 3.1.2-dev @preserve
+// dd-draggable.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/h5/dd-droppable.ts b/src/h5/dd-droppable.ts
@@ -1,4 +1,4 @@
-// dd-droppable.ts 3.1.2-dev @preserve
+// dd-droppable.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/h5/dd-element.ts b/src/h5/dd-element.ts
@@ -1,4 +1,4 @@
-// dd-elements.ts 3.1.2-dev @preserve
+// dd-elements.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/h5/dd-manager.ts b/src/h5/dd-manager.ts
@@ -1,4 +1,4 @@
-// dd-manager.ts 3.1.2-dev @preserve
+// dd-manager.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/h5/dd-resizable-handle.ts b/src/h5/dd-resizable-handle.ts
@@ -1,4 +1,4 @@
-// dd-resizable-handle.ts 3.1.2-dev @preserve
+// dd-resizable-handle.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/h5/dd-resizable.ts b/src/h5/dd-resizable.ts
@@ -1,4 +1,4 @@
-// dd-resizable.ts 3.1.2-dev @preserve
+// dd-resizable.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/h5/dd-utils.ts b/src/h5/dd-utils.ts
@@ -1,4 +1,4 @@
-// dd-utils.ts 3.1.2-dev @preserve
+// dd-utils.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/h5/gridstack-dd-native.ts b/src/h5/gridstack-dd-native.ts
@@ -1,4 +1,4 @@
-// gridstack-dd-native.ts 3.1.2-dev @preserve
+// gridstack-dd-native.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/index-h5.ts b/src/index-h5.ts
@@ -1,4 +1,4 @@
-// index.html5.ts 3.1.2-dev - everything you need for a Grid that uses HTML5 native drag&drop (work in progress) @preserve
+// index.html5.ts 3.1.3 - everything you need for a Grid that uses HTML5 native drag&drop (work in progress) @preserve
 
 // import './gridstack-poly.js';
 
diff --git a/src/index-jq.ts b/src/index-jq.ts
@@ -1,4 +1,4 @@
-// index.jq.ts 3.1.2-dev - everything you need for a Grid that uses Jquery-ui drag&drop (original, full feature) @preserve
+// index.jq.ts 3.1.3 - everything you need for a Grid that uses Jquery-ui drag&drop (original, full feature) @preserve
 
 // import './gridstack-poly.js';
 
diff --git a/src/index-static.ts b/src/index-static.ts
@@ -1,4 +1,4 @@
-// index.static.ts 3.1.2-dev - everything you need for a static Grid (non draggable) @preserve
+// index.static.ts 3.1.3 - everything you need for a static Grid (non draggable) @preserve
 
 // import './gridstack-poly.js';
 
diff --git a/src/jq/gridstack-dd-jqueryui.ts b/src/jq/gridstack-dd-jqueryui.ts
@@ -1,4 +1,4 @@
-// gridstack-dd-jqueryui.ts 3.1.2-dev @preserve
+// gridstack-dd-jqueryui.ts 3.1.3 @preserve
 
 /** JQuery UI Drag&Drop plugin
  * https://gridstackjs.com/
diff --git a/src/types.ts b/src/types.ts
@@ -1,4 +1,4 @@
-// types.ts 3.1.2-dev @preserve
+// types.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
diff --git a/src/utils.ts b/src/utils.ts
@@ -1,4 +1,4 @@
-// utils.ts 3.1.2-dev @preserve
+// utils.ts 3.1.3 @preserve
 
 /**
  * https://gridstackjs.com/
@@ -328,14 +328,12 @@ export class Utils {
     }
   }
 
-  /** 
-   * @internal
-   * 
-   * Function used to scroll the page.
-   * 
+  /**
+   * @internal Function used to scroll the page.
+   *
    * @param event `MouseEvent` that triggers the resize
    * @param el `HTMLElement` that's being resized
-   * @param distance Distance to scroll
+   * @param distance Distance from the V edges to start scrolling
    */
   static updateScrollResize(event: MouseEvent, el: HTMLElement, distance: number): void {
     const scrollEl = this.getScrollParent(el);
@@ -348,7 +346,6 @@ export class Utils {
       // This also can be done with a timeout to keep scrolling while the mouse is
       // in the scrolling zone. (will have smoother behavior)
       scrollEl.scrollBy({ behavior: 'smooth', top: event.clientY - distance});
-
     } else if (bottom) {
       scrollEl.scrollBy({ behavior: 'smooth', top: distance - (height - event.clientY)});
     }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "gridstack",`
`3`		`- "version": "3.1.2-dev",`
	`3`	`+ "version": "3.1.3",`
`4`	`4`	`"description": "TypeScript/Javascript lib for dashboard layout and creation, no external dependencies, with many wrappers (React, Angular, Ember, knockout...)",`
`5`	`5`	`"main": "./dist/gridstack.js",`
`6`	`6`	`"types": "./dist/gridstack.d.ts",`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// gridstack-GridStackDD.get().ts 3.1.2-dev @preserve`
	`1`	`+// gridstack-GridStackDD.get().ts 3.1.3 @preserve`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* https://gridstackjs.com/`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// gridstack-ddi.ts 3.1.2-dev @preserve`
	`1`	`+// gridstack-ddi.ts 3.1.3 @preserve`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* https://gridstackjs.com/`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// gridstack-engine.ts 3.1.2-dev @preserve`
	`1`	`+// gridstack-engine.ts 3.1.3 @preserve`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* https://gridstackjs.com/`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// gridstack.ts 3.1.2-dev @preserve`
	`1`	`+// gridstack.ts 3.1.3 @preserve`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* https://gridstackjs.com/`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// dd-base-impl.ts 3.1.2-dev @preserve`
	`1`	`+// dd-base-impl.ts 3.1.3 @preserve`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* https://gridstackjs.com/`