Skip to content

Commit 98041da

Browse files
committed
nested demo fix, bug template
1 parent 38c154b commit 98041da

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

ISSUE_TEMPLATE.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ Describe your issue here.
33

44
## Your environment
55
* version of gridstack.js AND if using HTML5 vs Jquery plugin (v3+) - DON'T SAY LATEST as that doesn't mean anything a month/year from now.
6-
* which browser and its version
6+
* which browser/OS
77

88
## Steps to reproduce
9-
MUST provide a working demo (keep it simple!) and steps, you can use this as a base:
10-
https://jsfiddle.net/adumesny/jqhkry7g
9+
You **MUST** provide a working demo (keep it simple!) and steps, you can use [this template](https://jsfiddle.net/adumesny/jqhkry7g) as a base.
10+
11+
If un-sure if lib bug, or questions use [slack channel](https://gridstackjs.troolee.com/) instead!
1112

1213
## Expected behavior
1314
Tell us what should happen

demo/nested.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,15 @@ <h1>Nested grids demo</h1>
5454
let grid = GridStack.addGrid(document.querySelector('.container-fluid'), json);
5555

5656
addNewWidget = function(selector) {
57+
let subGrid = document.querySelector(selector).gridstack;
5758
let node = {
58-
x: Math.round(12 * Math.random()),
59+
x: Math.round(6 * Math.random()),
5960
y: Math.round(5 * Math.random()),
60-
w: Math.round(1 + 3 * Math.random()),
61-
h: Math.round(1 + 3 * Math.random()),
61+
w: Math.round(1 + 1 * Math.random()),
62+
h: Math.round(1 + 1 * Math.random()),
6263
content: count++
6364
};
64-
grid.addWidget(node);
65+
subGrid.addWidget(node);
6566
return false;
6667
};
6768

doc/CHANGES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Change log
55
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
66
**Table of Contents** *generated with [DocToc](http://doctoc.herokuapp.com/)*
77

8+
- [4.0.3-dev](#403-dev)
89
- [4.0.3 (2021-3-28)](#403-2021-3-28)
910
- [4.0.2 (2021-3-27)](#402-2021-3-27)
1011
- [4.0.1 (2021-3-20)](#401-2021-3-20)
@@ -51,6 +52,8 @@ Change log
5152
- [v0.1.0 (2014-11-18)](#v010-2014-11-18)
5253

5354
<!-- END doctoc generated TOC please keep comment here to allow auto update -->
55+
## 4.0.3-dev
56+
5457
## 4.0.3 (2021-3-28)
5558

5659
- fix [#1693](https://github.com/gridstack/gridstack.js/issues/1693) `load` after `init()` broken in 4.x

0 commit comments

Comments
 (0)