Merge pull request #25 from grayloon/remove-out-if-sync-magento-categories

Remove old product links on sync

Author: ahinkle

src/Jobs/SyncMagentoProductCategories.php

@@ -3,6 +3,7 @@
 namespace Grayloon\MagentoStorage\Jobs;
 
 use Grayloon\Magento\Magento;
+use Grayloon\MagentoStorage\Models\MagentoProductCategory;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
@@ -36,6 +37,8 @@ public function handle()
         $this->links = (new Magento())->api('categories')
             ->products($this->categoryId)
             ->json();
+        
+        MagentoProductCategory::where('magento_category_id', $this->categoryId)->delete();
 
         foreach ($this->links as $link) {
             SyncMagentoProductCategory::dispatch($link['sku'], $this->categoryId, $link['position']);

tests/Jobs/SyncMagentoProductCategoriesTest.php

@@ -3,6 +3,7 @@
 namespace Grayloon\MagentoStorage\Tests\Jobs;
 
 use Grayloon\MagentoStorage\Database\Factories\MagentoCategoryFactory;
+use Grayloon\MagentoStorage\Database\Factories\MagentoProductCategoryFactory;
 use Grayloon\MagentoStorage\Database\Factories\MagentoProductFactory;
 use Grayloon\MagentoStorage\Jobs\SyncMagentoProductCategories;
 use Grayloon\MagentoStorage\Models\MagentoProductCategory;
@@ -45,4 +46,30 @@ public function test_can_sync_magento_product_categories_handles_empty_response(
 
         $this->assertEquals(0, MagentoProductCategory::count());
     }
+
+    /** @test */
+    public function it_removes_out_of_sync_categories()
+    {
+        config(['magento.store_code' => 'foo']);
+        $category = MagentoCategoryFactory::new()->create();
+        $oldProductLink = MagentoProductCategoryFactory::new()->create([
+            'magento_category_id' => $category->id,
+        ]);
+        $otherCategoryLink = MagentoProductCategoryFactory::new()->create();
+        $product = MagentoProductFactory::new()->create();
+        Http::fake([
+            '*rest/foo/V1/categories/'.$category->id.'/products' => Http::response([
+                [
+                    'sku' => $product->sku,
+                    'category_id' => $category->id,
+                    'position' => 1,
+                ],
+            ], 200),
+        ]);
+
+        (new SyncMagentoProductCategories($category->id))->handle();
+
+        $this->assertEquals(2, MagentoProductCategory::count());
+        $this->assertDeleted($oldProductLink);
+    }
 }