Skip to content

Commit 092bcaf

Browse files
committed
Defined all methods as default to simplify implementations.
1 parent 6065baa commit 092bcaf

File tree

2 files changed

+36
-19
lines changed

2 files changed

+36
-19
lines changed

src/main/java/org/gitlab4j/api/systemhooks/SystemHookListener.java

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
package org.gitlab4j.api.systemhooks;
33

44
/**
5-
* This class defines an event listener for the event fired when
5+
* This interface defines an event listener for the event fired when
66
* a System Hook notification has been received from a GitLab server.
77
*/
88
public interface SystemHookListener extends java.util.EventListener {
@@ -12,61 +12,70 @@ public interface SystemHookListener extends java.util.EventListener {
1212
*
1313
* @param event the ProjectSystemHookEvent instance
1414
*/
15-
public void onProjectEvent(ProjectSystemHookEvent event);
15+
default void onProjectEvent(ProjectSystemHookEvent event) {
16+
}
1617

1718
/**
1819
* This method is called when a System Hook team member event has been received.
1920
*
2021
* @param event the TeamMemberSystemHookEvent instance containing info on the team member event
2122
*/
22-
public void onTeamMemberEvent(TeamMemberSystemHookEvent event);
23+
default void onTeamMemberEvent(TeamMemberSystemHookEvent event) {
24+
}
2325

2426
/**
2527
* This method is called when a System Hook user event has been received.
2628
*
2729
* @param event the UserSystemHookEvent instance containing info on the user event
2830
*/
29-
public void onUserEvent(UserSystemHookEvent event);
31+
default void onUserEvent(UserSystemHookEvent event) {
32+
}
3033

3134
/**
3235
* This method is called when a System Hook key event has been received.
3336
*
3437
* @param event the KeySystemHookEvent instance containing info on the key event
3538
*/
36-
public void onKeyEvent(KeySystemHookEvent event);
39+
default void onKeyEvent(KeySystemHookEvent event) {
40+
}
3741

3842
/**
3943
* This method is called when a System Hook group event has been received.
4044
*
4145
* @param event the GroupSystemHookEvent instance containing info on the key event
4246
*/
43-
public void onGroupEvent(GroupSystemHookEvent event);
47+
default void onGroupEvent(GroupSystemHookEvent event) {
48+
}
4449

4550
/**
4651
* This method is called when a System Hook group member event has been received.
4752
*
4853
* @param event the GroupMemberSystemHookEvent instance containing info on the key event
4954
*/
50-
public void onGroupMemberEvent(GroupMemberSystemHookEvent event);
55+
default void onGroupMemberEvent(GroupMemberSystemHookEvent event) {
56+
}
5157

5258
/**
5359
* This method is called when a System Hook push event has been received.
5460
*
5561
* @param event the PushSystemHookEvent instance containing info on the key event
5662
*/
57-
public void onPushEvent(PushSystemHookEvent event);
63+
default void onPushEvent(PushSystemHookEvent event) {
64+
}
5865

5966
/**
6067
* This method is called when a System Hook tag push event has been received.
6168
*
6269
* @param event the TagPushSystemHookEvent instance containing info on the key event
6370
*/
64-
public void onTagPushEvent(TagPushSystemHookEvent event);
71+
default void onTagPushEvent(TagPushSystemHookEvent event) {
72+
}
6573

6674
/**
6775
* This method is called when a System Hook repository event has been received.
6876
*
6977
* @param event the RepositorySystemHookEvent instance containing info on the key event
7078
*/
71-
public void onRepositoryEvent(RepositorySystemHookEvent event);
79+
default void onRepositoryEvent(RepositorySystemHookEvent event) {
80+
}
7281
}

src/main/java/org/gitlab4j/api/webhook/WebHookListener.java

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import org.gitlab4j.api.webhook.PushEvent;
77

88
/**
9-
* This class defines an event listener for the event fired when
9+
* This interface defines an event listener for the event fired when
1010
* a WebHook notification has been received from a GitLab server.
1111
*/
1212
public interface WebHookListener extends java.util.EventListener {
@@ -16,54 +16,62 @@ public interface WebHookListener extends java.util.EventListener {
1616
*
1717
* @param buildEvent the BuildEvent instance
1818
*/
19-
public void onBuildEvent(BuildEvent buildEvent);
19+
default void onBuildEvent(BuildEvent buildEvent) {
20+
}
2021

2122
/**
2223
* This method is called when a WebHook issue event has been received.
2324
*
2425
* @param event the EventObject instance containing info on the issue
2526
*/
26-
public void onIssueEvent(IssueEvent event);
27+
default void onIssueEvent(IssueEvent event) {
28+
}
2729

2830
/**
2931
* This method is called when a WebHook merge request event has been received
3032
*
3133
* @param event the EventObject instance containing info on the merge request
3234
*/
33-
public void onMergeRequestEvent(MergeRequestEvent event);
35+
default void onMergeRequestEvent(MergeRequestEvent event) {
36+
}
3437

3538
/**
3639
* This method is called when a WebHook note event has been received.
3740
*
3841
* @param noteEvent theNoteEvent instance
3942
*/
40-
public void onNoteEvent(NoteEvent noteEvent);
43+
default void onNoteEvent(NoteEvent noteEvent) {
44+
}
4145

4246
/**
4347
* This method is called when a WebHook pipeline event has been received.
4448
*
4549
* @param pipelineEvent the PipelineEvent instance
4650
*/
47-
public void onPipelineEvent(PipelineEvent pipelineEvent);
51+
default void onPipelineEvent(PipelineEvent pipelineEvent) {
52+
}
4853

4954
/**
5055
* This method is called when a WebHook push event has been received.
5156
*
5257
* @param pushEvent the PushEvent instance
5358
*/
54-
public void onPushEvent(PushEvent pushEvent);
59+
default void onPushEvent(PushEvent pushEvent) {
60+
}
5561

5662
/**
5763
* This method is called when a WebHook tag push event has been received.
5864
*
5965
* @param tagPushEvent the TagPushEvent instance
6066
*/
61-
public void onTagPushEvent(TagPushEvent tagPushEvent);
67+
default void onTagPushEvent(TagPushEvent tagPushEvent) {
68+
}
6269

6370
/**
6471
* This method is called when a WebHook wiki page event has been received.
6572
*
6673
* @param wikiEvent the WikiPageEvent instance
6774
*/
68-
public void onWikiPageEvent(WikiPageEvent wikiEvent);
75+
default void onWikiPageEvent(WikiPageEvent wikiEvent) {
76+
}
6977
}

0 commit comments

Comments
 (0)