Skip to content

Commit 268f6b8

Browse files
committed
Minor Changes
1 parent 7942b26 commit 268f6b8

File tree

6 files changed

+5
-16
lines changed

6 files changed

+5
-16
lines changed

src/js/__tests__/components/settings-modal.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -136,13 +136,6 @@ describe('components/settings-modal.js', () => {
136136
expect(props.toggleSettingsModal).toHaveBeenCalledTimes(1);
137137
});
138138

139-
it('should close the modal pressing the close button', () => {
140-
const wrapper = shallow(<SettingsModal {...props} />);
141-
expect(wrapper).toBeDefined();
142-
wrapper.find('.btn-secondary').simulate('click');
143-
expect(props.toggleSettingsModal).toHaveBeenCalledTimes(1);
144-
});
145-
146139
it('should toggle the showOnlyParticipating checbox', () => {
147140
const wrapper = shallow(<SettingsModal {...props} />);
148141
expect(wrapper).toBeDefined();

src/js/components/logos/dark.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export default class LogoWhite extends React.PureComponent {
99
render() {
1010
/* eslint-disable */
1111
return (
12-
<svg className="logo" onClick={() => this.props.onClick && this.props.onClick()} xmlns="http://www.w3.org/2000/svg" xmlnsXlink="http://www.w3.org/1999/xlink" viewBox="0 0 180.31 182.52">
12+
<svg className={`logo ${this.props.className}`} onClick={() => this.props.onClick && this.props.onClick()} xmlns="http://www.w3.org/2000/svg" xmlnsXlink="http://www.w3.org/1999/xlink" viewBox="0 0 180.31 182.52">
1313
<defs>
1414

1515
<linearGradient id="linear-dark-gradient" x1="300.53" y1="294.89" x2="130.22" y2="240.53" gradientUnits="userSpaceOnUse">

src/js/components/logos/white.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export default class LogoWhite extends React.PureComponent {
99
render() {
1010
/* eslint-disable */
1111
return (
12-
<svg className="logo" onClick={() => this.props.onClick && this.props.onClick()} xmlns="http://www.w3.org/2000/svg" xmlnsXlink="http://www.w3.org/1999/xlink" viewBox="0 0 180.31 182.52">
12+
<svg className={`logo ${this.props.className}`} onClick={() => this.props.onClick && this.props.onClick()} xmlns="http://www.w3.org/2000/svg" xmlnsXlink="http://www.w3.org/1999/xlink" viewBox="0 0 180.31 182.52">
1313
<defs>
1414

1515
<linearGradient id="linear-white-gradient" x1="300.53" y1="294.89" x2="130.22" y2="240.53" gradientUnits="userSpaceOnUse">

src/js/components/settings-modal.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,7 @@ export class SettingsModal extends React.Component {
130130

131131
<div className="modal-footer">
132132
<button className="btn btn-outline-danger" onClick={() => this.logout()}>
133-
<span className="octicon octicon-sign-out" /> Logout
134-
</button>
135-
136-
<button className="btn btn-secondary" onClick={() => this.props.toggleSettingsModal()}>
137-
Close
133+
<span className="octicon octicon-sign-out" /> Logout from all accounts
138134
</button>
139135
</div>
140136
</div>

src/js/components/sidebar.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export class Sidebar extends React.Component {
6868
<div
6969
key={idx}
7070
title={account.get('hostname')}
71-
className={`badge-account${(enterpriseAccounts.size === idx + 1) && ' last'}`}
71+
className={`badge-account${(enterpriseAccounts.size === idx + 1) ? ' last' : ''}`}
7272
>
7373
<div className="mr-auto name">{accountDomain}</div>
7474
<div>{notificationsCount === 0 ? <span className="octicon octicon-check" /> : notificationsCount}</div>

src/js/routes/login.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export class LoginPage extends React.Component {
2323

2424
return (
2525
<div className="container-fluid main-container login">
26-
<LogoDark />
26+
<LogoDark className="mt-5" />
2727

2828
<div className="desc">GitHub Notifications<br />in your menu bar.</div>
2929
<button

0 commit comments

Comments
 (0)