Split to 'sound-notification' store & get the correct full_name & subject title

Author: Emmanouil Konstantinidis

src/js/actions/actions.js

@@ -5,6 +5,7 @@ var Actions = Reflux.createActions({
   'login': {},
   'logout': {},
   'getNotifications': {asyncResult: true},
+  'isNewNotification': {},
   'updateSearchTerm': {},
   'clearSearchTerm': {},
   'setSetting': {}

src/js/stores/notifications.js

@@ -11,7 +11,6 @@ var NotificationsStore = Reflux.createStore({
 
   init: function () {
     this._notifications = [];
-    this._previousNotifications = [];
   },
 
   updateTrayIcon: function (notifications) {
@@ -22,50 +21,6 @@ var NotificationsStore = Reflux.createStore({
     }
   },
 
-  isNewNotification: function (response) {
-    var self = this;
-    var playSound = SettingsStore.getSettings().playSound;
-    var showNotifications = SettingsStore.getSettings().showNotifications;
-
-    if (!playSound && !showNotifications) { return; }
-
-    // Check if notification is already in the store.
-    var countNew = 0;
-    _.map(response, function (obj) {
-      if (!_.contains(self._previousNotifications, obj.id)) {
-        countNew ++;
-      }
-    });
-
-    // Play Sound.
-    if (countNew > 0) {
-      if (playSound) {
-        var audio = new Audio('sounds/digi.wav');
-        audio.play();
-      }
-      if (showNotifications) {
-        var title = (countNew == 1 ?
-          'Gitify - ' + response[0].repository.full_name :
-          'Gitify');
-        var body = (countNew == 1 ?
-          response[0].subject.title :
-          'You\'ve got ' + countNew + ' notifications.');
-        var nativeNotification = new Notification(title, {
-          body: body
-        });
-        nativeNotification.onclick = function () {
-          ipc.sendChannel('reopen-window');
-        };
-      }
-    }
-
-    // Now Reset the previousNotifications array.
-    self._previousNotifications = [];
-    _.map(response, function (obj) {
-      self._previousNotifications.push(obj.id);
-    });
-  },
-
   onGetNotifications: function () {
     var self = this;
     var participating = SettingsStore.getSettings().participating;
@@ -78,7 +33,7 @@ var NotificationsStore = Reflux.createStore({
           // Success - Do Something.
           Actions.getNotifications.completed(response.body);
           self.updateTrayIcon(response.body);
-          self.isNewNotification(response.body);
+          Actions.isNewNotification(response.body);
         } else {
           // Error - Show messages.
           Actions.getNotifications.failed(err);

src/js/stores/sound-notification.js

@@ -0,0 +1,74 @@
+var ipc = window.require('ipc');
+var Reflux = require('reflux');
+var _ = require('underscore');
+
+var Actions = require('../actions/actions');
+var SettingsStore = require('../settings');
+
+var SoundNotificationStore = Reflux.createStore({
+  listenables: Actions,
+
+  init: function () {
+    this._previousNotifications = [];
+  },
+
+  playSound: function () {
+    var audio = new Audio('sounds/digi.wav');
+    audio.play();
+  },
+
+  showNotification: function (countNew, response, latestNotification) {
+    var title = (countNew == 1 ?
+      'Gitify - ' + latestNotification.full_name :
+      'Gitify');
+    var body = (countNew == 1 ?
+      latestNotification.subject :
+      'You\'ve got ' + countNew + ' notifications.');
+    var nativeNotification = new Notification(title, {
+      body: body
+    });
+    nativeNotification.onclick = function () {
+      ipc.sendChannel('reopen-window');
+    };
+  },
+
+  onIsNewNotification: function (response) {
+    var self = this;
+    var playSound = SettingsStore.getSettings().playSound;
+    var showNotifications = SettingsStore.getSettings().showNotifications;
+
+    if (!playSound && !showNotifications) { return; }
+
+    // Check if notification is already in the store.
+    var countNew = 0;
+    var latestNotification = {};
+    _.map(response, function (obj) {
+      if (!_.contains(self._previousNotifications, obj.id)) {
+        countNew ++;
+        latestNotification = {
+          full_name: obj.repository.full_name,
+          subject: obj.subject.title
+        };
+      }
+    });
+
+    // Play Sound / Show Notification.
+    if (countNew > 0) {
+      if (playSound) {
+        self.playSound();
+      }
+      if (showNotifications) {
+        self.showNotification(countNew, response, latestNotification);
+      }
+    }
+
+    // Now Reset the previousNotifications array.
+    self._previousNotifications = [];
+    _.map(response, function (obj) {
+      self._previousNotifications.push(obj.id);
+    });
+  }
+
+});
+
+module.exports = SoundNotificationStore;