-
Notifications
You must be signed in to change notification settings - Fork 108
Set rm_files to be a synchronous method #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anjaliratnam-msft
wants to merge
1
commit into
fsspec:main
Choose a base branch
from
anjaliratnam-msft:rm_files_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this is something that I missed as well when we went over the original GitHub feature request... Based on the fsspec specification there is no
rm_files()
shared interface; there's only anrm_file()
. The original GitHub issue: #497 is also only requesting forrm_file()
.So, it is not appropriate to be setting a sync wrapper like this because it does not appear
rm_files
to be a shared interface across file systems. Instead, it would probably make sense to add an async_rm_file
that is a simplified wrapper over the_rm
implementation to implement the feature request.Even more interesting, it seems there used to be a
_rm_file()
implementation prior to this PR: #383 and because the underlyingAsyncFileSystem
mirrors methods, I suspect thatadlfs
might have actually at one point supportedrm_file()
and could be a regression. It would be great to confirm ifadlfs
ever supportedrm_file()
in a version prior to that PR.