From 45a4321ec4f9e8066b4322c1dabc92e8e0ecf567 Mon Sep 17 00:00:00 2001 From: itsasecret <87604944+tudorpintea999@users.noreply.github.com> Date: Tue, 21 Jan 2025 22:31:13 +0200 Subject: [PATCH 1/6] Update parse-sign-in-uri.md --- docs/auth-kit/client/wallet/parse-sign-in-uri.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/auth-kit/client/wallet/parse-sign-in-uri.md b/docs/auth-kit/client/wallet/parse-sign-in-uri.md index 9eebe2b1..ff4af479 100644 --- a/docs/auth-kit/client/wallet/parse-sign-in-uri.md +++ b/docs/auth-kit/client/wallet/parse-sign-in-uri.md @@ -4,7 +4,7 @@ Parse the Sign In With Farcaster URI provided by a connected app user. Returns the parsed parameters. Your app should use these to construct a Sign In With Farcaster message. -Returns an error if URI is invalid. +Returns an error if the URI is invalid. ```ts const params = walletClient.parseSignInURI({ From 5db83596ec05203ecb46cf43e522e9b68785139e Mon Sep 17 00:00:00 2001 From: itsasecret <87604944+tudorpintea999@users.noreply.github.com> Date: Tue, 21 Jan 2025 22:34:31 +0200 Subject: [PATCH 2/6] Update getting-started.md --- docs/developers/frames/v2/getting-started.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/developers/frames/v2/getting-started.md b/docs/developers/frames/v2/getting-started.md index e68e1fb3..70cbbab2 100644 --- a/docs/developers/frames/v2/getting-started.md +++ b/docs/developers/frames/v2/getting-started.md @@ -16,7 +16,7 @@ Here's a full walkthrough of creating a frames v2 app: ## Tutorial -The following tutorial is based on the [Frames v2 Demo](https://github.com/farcasterxyz/frames-v2-demo) repo on Github. +The following tutorial is based on the [Frames v2 Demo](https://github.com/farcasterxyz/frames-v2-demo) repo on GitHub. ### Setup and dependencies @@ -286,7 +286,7 @@ $ ngrok http http://localhost:3000 ``` ::: info Tunneling gotchas -Some tunneling tools, like the ngrok free tier, insert an click-through interstitial between your dev server and the tunnel endpoint. Use a paid ngrok account or a different tool, like Tailscale funnel. +Some tunneling tools, like the ngrok free tier, insert a click-through interstitial between your dev server and the tunnel endpoint. Use a paid ngrok account or a different tool, like Tailscale funnel. ::: Now open the Frame Playground on Warpcast mobile, by visiting [https://warpcast.com/~/developers/frame](https://warpcast.com/~/developers/frames). From 76d34c112832da42d9876d1b1a26d2efb00a8235 Mon Sep 17 00:00:00 2001 From: itsasecret <87604944+tudorpintea999@users.noreply.github.com> Date: Tue, 21 Jan 2025 22:34:46 +0200 Subject: [PATCH 3/6] Update index.md --- docs/developers/frames/v2/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developers/frames/v2/index.md b/docs/developers/frames/v2/index.md index 83f83b01..0f2a703a 100644 --- a/docs/developers/frames/v2/index.md +++ b/docs/developers/frames/v2/index.md @@ -1,6 +1,6 @@ # Frames v2 Introduction -[Frames](../index.md) launched in January 2024 as a a way to build interactive apps that run directly in a Farcaster social feed. They enabled developers to identify users, connect wallets, and take limited actions on and offchain. +[Frames](../index.md) launched in January 2024 as a way to build interactive apps that run directly in a Farcaster social feed. They enabled developers to identify users, connect wallets, and take limited actions on and offchain. Although we saw many apps built, they were held back by several limitations: From 440b7340c595c0b57f424360a3b26cf827f815ad Mon Sep 17 00:00:00 2001 From: itsasecret <87604944+tudorpintea999@users.noreply.github.com> Date: Tue, 21 Jan 2025 22:35:42 +0200 Subject: [PATCH 4/6] Update notifications_webhooks.md --- docs/developers/frames/v2/notifications_webhooks.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developers/frames/v2/notifications_webhooks.md b/docs/developers/frames/v2/notifications_webhooks.md index f9b6aa46..afcd6600 100644 --- a/docs/developers/frames/v2/notifications_webhooks.md +++ b/docs/developers/frames/v2/notifications_webhooks.md @@ -4,7 +4,7 @@ title: Frames v2 Notifications & Webhooks # Frames v2 Notifications & Webhooks -Frames v2 allow developers to send notifications to users who have "added" the frame to their Farcaster client and enabled notifications. +Frames v2 allows developers to send notifications to users who have "added" the frame to their Farcaster client and enabled notifications. In Warpcast, these are **in-app notifications** that trigger the red dot on the notifications tab. At this stage there is no support for push notifications. From f0e6d99648667cdf32e1773aa2de604fe9b4f7dd Mon Sep 17 00:00:00 2001 From: itsasecret <87604944+tudorpintea999@users.noreply.github.com> Date: Tue, 21 Jan 2025 22:46:26 +0200 Subject: [PATCH 5/6] Update spec.md --- docs/developers/frames/v2/spec.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developers/frames/v2/spec.md b/docs/developers/frames/v2/spec.md index 625db11d..4ee117c8 100644 --- a/docs/developers/frames/v2/spec.md +++ b/docs/developers/frames/v2/spec.md @@ -509,7 +509,7 @@ bottom of the view. ### actions.ready -Indicates that the application is fully loaded and ready to displayed to users. Once this is called the loading screen will be hidden. Frame applications MUST call `ready()` to display their app. +Indicates that the application is fully loaded and ready to be displayed to users. Once this is called the loading screen will be hidden. Frame applications MUST call `ready()` to display their app. ```ts > await sdk.actions.ready(); From 6190a86fd901b75431ef2c5ca81d89bba06821f4 Mon Sep 17 00:00:00 2001 From: itsasecret <87604944+tudorpintea999@users.noreply.github.com> Date: Wed, 22 Jan 2025 00:38:06 +0200 Subject: [PATCH 6/6] Update spec.md --- docs/developers/frames/spec.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/developers/frames/spec.md b/docs/developers/frames/spec.md index 69780f82..f7b1b80f 100644 --- a/docs/developers/frames/spec.md +++ b/docs/developers/frames/spec.md @@ -349,7 +349,7 @@ Apps should consider the following mechanisms to protect users against malicious 1. Transaction simulation. 2. Domain allowlisting and banlisting to stop known attackers. 3. Social graph analysis to detect potential bad or untrusted actors. -4. Educating users about the potential dangerous of transactions and using a wallet with limited balances. +4. Educating users about the potential dangers of transactions and using a wallet with limited balances. ## Data Structures