Andrew hung nguyen (#32)

* hacktoberfest contribution - binary to hexadecimal

* Adding regexp to detect invalid expressions and unit test cases

* Added a function that converts from binary to octal and included unit tests for it

Author: AndrewHUNGNguyen

easyPythonpi/TestBin2Hex.py

@@ -133,8 +133,62 @@ def test_invalid_regexpression(self):
         with self.assertRaises(easyPythonpi.InvalidBinaryException):
             easyPythonpi.bin2hex('[0-1]')                        
 
-
- # class TestBin2Octal(unittest.TestCase):                                                                  
+    
+class TestBin2Octal(unittest.TestCase): 
+    def test_single_binary_zero(self):
+        self.assertEqual( easyPythonpi.bin2oct('0'), '0')
+    def test_single_binary_one(self):
+        self.assertEqual( easyPythonpi.bin2oct('1'), '1')       
+    def test_single_binary_triple_zero(self):
+        self.assertEqual( easyPythonpi.bin2oct('000'), '0')    
+    def test_single_binary_001(self):
+        self.assertEqual( easyPythonpi.bin2oct('001'), '1') 
+    def test_single_binary_010(self):
+        self.assertEqual( easyPythonpi.bin2oct('010'), '2')   
+    def test_single_binary_011(self):
+        self.assertEqual( easyPythonpi.bin2oct('011'), '3')                 
+    def test_single_binary_100(self):
+        self.assertEqual( easyPythonpi.bin2oct('100'), '4') 
+    def test_single_binary_101(self):
+        self.assertEqual( easyPythonpi.bin2oct('101'), '5') 
+    def test_single_binary_110(self):
+        self.assertEqual( easyPythonpi.bin2oct('110'), '6') 
+    def test_single_binary_111(self):
+        self.assertEqual( easyPythonpi.bin2oct('111'), '7') 
+    def test_single_binary_000010(self):
+        self.assertEqual( easyPythonpi.bin2oct('000010'), '02') 
+    def test_single_binary_00010(self):
+        self.assertEqual( easyPythonpi.bin2oct('00010'), '02')     
+    def test_invalid_binary_A(self):
+        with self.assertRaises(easyPythonpi.InvalidBinaryException):
+            easyPythonpi.bin2oct('A') 
+    def test_invalid_binary_123(self):
+        with self.assertRaises(easyPythonpi.InvalidBinaryException):
+            easyPythonpi.bin2oct('123')  
+    def test_invalid_binary_0101A1000100(self):
+        with self.assertRaises(easyPythonpi.InvalidBinaryException):
+            easyPythonpi.bin2oct('0101A1000100')  
+    def test_invalid_binary_A101100010B(self):
+        with self.assertRaises(easyPythonpi.InvalidBinaryException):
+            easyPythonpi.bin2oct('A101100010B')  
+    def test_invalid_binary_nonalphanumeric(self):
+        with self.assertRaises(easyPythonpi.InvalidBinaryException):
+            easyPythonpi.bin2oct('!')    
+    def test_invalid_binary_nonalphanumeric_in_binary(self):
+        with self.assertRaises(easyPythonpi.InvalidBinaryException):
+            easyPythonpi.bin2oct('001~') 
+    def test_invalid_binary_subtraction(self):
+        with self.assertRaises(easyPythonpi.InvalidBinaryException):
+            easyPythonpi.bin2oct('0000-1000')            
+    def test_invalid_binary_anding(self):
+        with self.assertRaises(easyPythonpi.InvalidBinaryException):
+            easyPythonpi.bin2oct('0000&1000')   
+    def test_invalid_helloWorld_expression(self):
+        with self.assertRaises(easyPythonpi.InvalidBinaryException):
+            easyPythonpi.bin2oct('hello world')    
+    def test_invalid_regexpression(self):
+        with self.assertRaises(easyPythonpi.InvalidBinaryException):
+            easyPythonpi.bin2oct('[0-1]')  
 
 if __name__ == '__main__':
     unittest.main()

easyPythonpi/easyPythonpi.py

@@ -208,8 +208,50 @@ def bin2hex(x:'bin')->'hex':
             h = 'E' + h
         elif substring == '1111':
             h = 'F' + h
+            
+    return h 
+
+
+def bin2oct(x:'bin')->'oct':  
+    o = ''  # hexadecimal number converted from binary and to be returned
+
+    x=str(x)
+    
+    # Determine if the string has invalid characters
+    if re.search('[^(0-1)]', x):
+        raise InvalidBinaryException 
+
+    # Get the length of the string
+    l=len(x)
+
+    # Begin the process of converting x to its hexadecimal number
+
+    # If the length is not a multiple of 3, prepend 0's before converting
+    if l % 3 != 0:
+        numZerosPrepended = 3 - ( l % 3 ) # number of zeros to prepend 
+        x = (numZerosPrepended * '0') + x # concatenate numZerosPrepended to x
 
-    return h        
+    for i in range(len(x), 0, -3):
+        substring = x[i-3:i]
+
+        if substring == '000':
+            o = '0' + o
+        elif substring == '001':
+            o = '1' + o
+        elif substring == '010':
+            o = '2' + o
+        elif substring == '011':
+            o = '3' + o
+        elif substring == '100':
+            o = '4' + o                        
+        elif substring == '101':
+            o = '5' + o        
+        elif substring == '110':
+            o = '6' + o
+        elif substring == '111':
+            o = '7' + o    
+
+    return o
 
 def createarray(length:'int',dtype='int')->'array':   # To create an array of entered length and entered data type(interger data type is a default data type)
     import numpy as np