hm1055: fix set_brightness error handling & logging #770
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code always wrote BRIGHT even if enabling ISPCTRL5 failed, while also overwriting the first error code. It also used `if (ret != 0)` to log/update status, so we reported success when the write actually failed. Guard the BRIGHT write behind a successful ISPCTRL5 write and only log / update `sensor->status.brightness` when both writes succeed. This keeps the original error, and prevents false success reports.
|
i guess this is true not just for that method but to all similar ones. Do you mind fixing them all? |
|
@me-no-dev wrote:
Yeah, I'm already working on the rest for a dedicated PR. This is a bit more critical, the rest is more cosmetic :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old code always wrote BRIGHT even if enabling ISPCTRL5 failed, while also overwriting the first error code. It also used
if (ret != 0)to log/update status, so we reported success when the write actually failed.Guard the BRIGHT write behind a successful ISPCTRL5 write and only log / update
sensor->status.brightnesswhen both writes succeed. This keeps the original error, and prevents false success reports.Testing
I don't own the hardware.
Checklist
Before submitting a Pull Request, please ensure the following: