add tests for exceptions

Author: efureev

src/Exceptions/ConfigException.php

@@ -20,7 +20,7 @@ class ConfigException extends Exception
      * @param null   $config
      * @param string $message
      */
-    public function __construct($config = null, $message = 'Config Exception')
+    public function __construct($message = 'Config Exception', $config = null)
     {
         parent::__construct($message);
 

src/Exceptions/MissingPropertyException.php

@@ -13,17 +13,28 @@ class MissingPropertyException extends ConfigException
     protected $property;
 
     /**
-     * MissingConfigException constructor.
+     * MissingPropertyException constructor.
      *
-     * @param mixed  $config
-     * @param string $property
+     * @param null|string $message
+     * @param null|string $property
      */
-    public function __construct($config = null, $property = null)
+    public function __construct(?string $message = null, ?string $property = null)
     {
         $this->property = $property;
-        parent::__construct($config, sprintf('Missing property "%s" in config', $this->property));
+        parent::__construct($message ?? ($this->getName() . ($this->property ? ': "' . $this->property . '"' : '')));
     }
 
+    /**
+     * @return string
+     */
+    public function getName()
+    {
+        return 'Missing property';
+    }
+
+    /**
+     * @return null|string
+     */
     public function getProperty(): ?string
     {
         return $this->property;

src/Exceptions/UnknownMethodException.php

@@ -18,10 +18,18 @@ class UnknownMethodException extends \BadMethodCallException
      * @param null|string $method
      * @param null|string $message
      */
-    public function __construct(?string $method = null, ?string $message = null)
+    public function __construct(?string $message = null, ?string $method = null)
     {
         $this->method = $method;
-        parent::__construct($message ?? sprintf('Missing method "%s" ', $this->method));
+        parent::__construct($message ?? ($this->getName() . ($this->method ? ': "'.$this->method.'"': '')));
+    }
+
+    /**
+     * @return string
+     */
+    public function getName()
+    {
+        return 'Unknown method';
     }
 
     /**

src/Exceptions/UnknownPropertyException.php

@@ -18,10 +18,18 @@ class UnknownPropertyException extends Exception
      * @param null|string $property
      * @param null|string $message
      */
-    public function __construct(?string $property = null, ?string $message = null)
+    public function __construct(?string $message = null, ?string $property = null)
     {
         $this->property = $property;
-        parent::__construct($message ?? sprintf('Missing property "%s" ', $this->property));
+        parent::__construct($message ?? ($this->getName() . ($this->property ? ': "'.$this->property.'"': '')));
+    }
+
+    /**
+     * @return string
+     */
+    public function getName()
+    {
+        return 'Unknown property';
     }
 
     /**

tests/exceptions/MissingPropertyTest.php

@@ -0,0 +1,35 @@
+<?php
+declare(strict_types=1);
+
+use Php\Support\Exceptions\MissingPropertyException;
+use PHPUnit\Framework\TestCase;
+
+final class MissingPropertyTest extends TestCase
+{
+    public function testThrow()
+    {
+        try {
+            throw new MissingPropertyException('Invalid Arg');
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(MissingPropertyException::class, $e);
+            $this->assertSame('Invalid Arg', $e->getMessage());
+        }
+
+        try {
+            throw new MissingPropertyException(null, 'test');
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(MissingPropertyException::class, $e);
+            $this->assertSame('Missing property', $e->getName());
+            $this->assertSame('Missing property: "test"', $e->getMessage());
+            $this->assertSame('test', $e->getProperty());
+        }
+
+        try {
+            throw new MissingPropertyException();
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(MissingPropertyException::class, $e);
+            $this->assertSame('Missing property', $e->getName());
+            $this->assertSame('Missing property', $e->getMessage());
+        }
+    }
+}

tests/exceptions/UnknownMethodTest.php

@@ -0,0 +1,35 @@
+<?php
+declare(strict_types=1);
+
+use Php\Support\Exceptions\UnknownMethodException;
+use PHPUnit\Framework\TestCase;
+
+final class UnknownMethodTest extends TestCase
+{
+    public function testThrow()
+    {
+        try {
+            throw new UnknownMethodException('Invalid Arg');
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(UnknownMethodException::class, $e);
+            $this->assertSame('Invalid Arg', $e->getMessage());
+        }
+
+        try {
+            throw new UnknownMethodException(null, 'test');
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(UnknownMethodException::class, $e);
+            $this->assertSame('Unknown method', $e->getName());
+            $this->assertSame('Unknown method: "test"', $e->getMessage());
+            $this->assertSame('test', $e->getMethod());
+        }
+
+        try {
+            throw new UnknownMethodException();
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(UnknownMethodException::class, $e);
+            $this->assertSame('Unknown method', $e->getName());
+            $this->assertSame('Unknown method', $e->getMessage());
+        }
+    }
+}

tests/exceptions/UnknownPropertyTest.php

@@ -0,0 +1,35 @@
+<?php
+declare(strict_types=1);
+
+use Php\Support\Exceptions\UnknownPropertyException;
+use PHPUnit\Framework\TestCase;
+
+final class UnknownPropertyTest extends TestCase
+{
+    public function testThrow()
+    {
+        try {
+            throw new UnknownPropertyException('Invalid Arg');
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(UnknownPropertyException::class, $e);
+            $this->assertSame('Invalid Arg', $e->getMessage());
+        }
+
+        try {
+            throw new UnknownPropertyException(null, 'test');
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(UnknownPropertyException::class, $e);
+            $this->assertSame('Unknown property', $e->getName());
+            $this->assertSame('Unknown property: "test"', $e->getMessage());
+            $this->assertSame('test', $e->getProperty());
+        }
+
+        try {
+            throw new UnknownPropertyException();
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(UnknownPropertyException::class, $e);
+            $this->assertSame('Unknown property', $e->getName());
+            $this->assertSame('Unknown property', $e->getMessage());
+        }
+    }
+}