ci: fix for php 8.4

fureev · fureev · commit b8cab074f394 · 2024-12-25T15:04:34.000+02:00
diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml
@@ -37,7 +37,7 @@ jobs:
       fail-fast: false
       matrix:
         setup: [ 'basic', 'lowest', 'stable' ]
-        php: [ '8.1' ,'8.2', '8.3' ]
+        php: [ '8.4' ]
 
     steps:
       - uses: actions/checkout@v4
diff --git a/src/Exceptions/MissingPropertyException.php b/src/Exceptions/MissingPropertyException.php
@@ -11,7 +11,7 @@ class MissingPropertyException extends ConfigException
 {
     public function __construct(protected(set) ?string $property, ?string $message = null, array $config = [])
     {
-        parent::__construct($message ?? ($this->getName() . ": '$this->property'"), $config);
+        parent::__construct($message ?? ($this->getName() . ": $this->property"), $config);
     }
 
     /**
diff --git a/src/Exceptions/UnknownMethodException.php b/src/Exceptions/UnknownMethodException.php
@@ -14,7 +14,7 @@ class UnknownMethodException extends BadMethodCallException
     public function __construct(protected(set) string $method, ?string $message = null)
     {
         $this->method = $method;
-        parent::__construct($message ?? ($this->getName() . ": $this->method "));
+        parent::__construct($message ?? ($this->getName() . ": $this->method"));
     }
 
     /**
diff --git a/tests/Enums/WithEnhancesForStringsTest.php b/tests/Enums/WithEnhancesForStringsTest.php
@@ -2,9 +2,9 @@
 
 declare(strict_types=1);
 
-namespace Php\Support\Tests\enums;
+namespace Php\Support\Tests\Enums;
 
-use Php\Support\Tests\enums\data\StringsEnum;
+use Php\Support\Tests\Enums\data\StringsEnum;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 
diff --git a/tests/Enums/data/StringsEnum.php b/tests/Enums/data/StringsEnum.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Php\Support\Tests\enums\data;
+namespace Php\Support\Tests\Enums\data;
 
 use Php\Support\Enums\WithEnhancesForStrings;
 
diff --git a/tests/Exceptions/ExceptionTest.php b/tests/Exceptions/ExceptionTest.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Php\Support\Tests;
+namespace Php\Support\Tests\Exceptions;
 
 use Php\Support\Exceptions\Exception;
 use PHPUnit\Framework\TestCase;
diff --git a/tests/Exceptions/InvalidArgumentTest.php b/tests/Exceptions/InvalidArgumentTest.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Php\Support\Tests;
+namespace Php\Support\Tests\Exceptions;
 
 use Php\Support\Exceptions\InvalidArgumentException;
 use PHPUnit\Framework\TestCase;
diff --git a/tests/Exceptions/InvalidParamTest.php b/tests/Exceptions/InvalidParamTest.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Php\Support\Tests;
+namespace Php\Support\Tests\Exceptions;
 
 use Php\Support\Exceptions\InvalidParamException;
 use PHPUnit\Framework\TestCase;
diff --git a/tests/Exceptions/MissingClassTest.php b/tests/Exceptions/MissingClassTest.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Php\Support\Tests;
+namespace Php\Support\Tests\Exceptions;
 
 use Php\Support\Exceptions\MissingClassException;
 use PHPUnit\Framework\TestCase;
@@ -15,26 +15,13 @@ final class MissingClassTest extends TestCase
 {
     public function testThrow()
     {
-        try {
-            throw new MissingClassException();
-        } catch (Throwable $e) {
-            $this->assertInstanceOf(MissingClassException::class, $e);
-            $this->assertSame('Missing Class', $e->getMessage());
-        }
-
         try {
             throw new MissingClassException(MissingClassException::class);
         } catch (Throwable $e) {
             $this->assertInstanceOf(MissingClassException::class, $e);
             $this->assertSame('Missing Class: ' . MissingClassException::class, $e->getMessage());
         }
 
-        try {
-            throw new MissingClassException(null, 'Test Message');
-        } catch (Throwable $e) {
-            $this->assertInstanceOf(MissingClassException::class, $e);
-            $this->assertSame('Test Message', $e->getMessage());
-        }
         try {
             throw new MissingClassException(MissingClassException::class, 'Test Message');
         } catch (Throwable $e) {
diff --git a/tests/Exceptions/MissingPropertyTest.php b/tests/Exceptions/MissingPropertyTest.php
@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Php\Support\Tests\Exceptions;
+
+use Php\Support\Exceptions\MissingPropertyException;
+use PHPUnit\Framework\TestCase;
+use Throwable;
+
+/**
+ * Class MissingPropertyTest
+ */
+final class MissingPropertyTest extends TestCase
+{
+    public function testThrow()
+    {
+        try {
+            throw new MissingPropertyException('test');
+        } catch (Throwable $e) {
+            $this->assertInstanceOf(MissingPropertyException::class, $e);
+            $this->assertSame('Missing property: test', $e->getMessage());
+            $this->assertSame('test', $e->property);
+        }
+    }
+}
diff --git a/tests/Exceptions/NotSupportedTest.php b/tests/Exceptions/NotSupportedTest.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Php\Support\Tests;
+namespace Php\Support\Tests\Exceptions;
 
 use Php\Support\Exceptions\NotSupportedException;
 use PHPUnit\Framework\TestCase;
diff --git a/tests/Exceptions/UnknownMethodTest.php b/tests/Exceptions/UnknownMethodTest.php
@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Php\Support\Tests\Exceptions;
+
+use Php\Support\Exceptions\UnknownMethodException;
+use PHPUnit\Framework\TestCase;
+use Throwable;
+
+/**
+ * Class UnknownMethodTest
+ */
+final class UnknownMethodTest extends TestCase
+{
+    public function testThrow()
+    {
+        try {
+            throw new UnknownMethodException('method');
+        } catch (Throwable $e) {
+            $this->assertInstanceOf(UnknownMethodException::class, $e);
+            $this->assertSame('Unknown method: method', $e->getMessage());
+        }
+    }
+}
diff --git a/tests/Exceptions/UnknownPropertyTest.php b/tests/Exceptions/UnknownPropertyTest.php
@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Php\Support\Tests\Exceptions;
+
+use Php\Support\Exceptions\UnknownPropertyException;
+use PHPUnit\Framework\TestCase;
+use Throwable;
+
+/**
+ * Class UnknownPropertyTest
+ */
+final class UnknownPropertyTest extends TestCase
+{
+    public function testThrow()
+    {
+        try {
+            throw new UnknownPropertyException('test');
+        } catch (Throwable $e) {
+            $this->assertInstanceOf(UnknownPropertyException::class, $e);
+            $this->assertSame('Unknown property: test', $e->getMessage());
+            $this->assertSame('test', $e->property);
+        }
+    }
+}
diff --git a/tests/exceptions/MissingPropertyTest.php b/tests/exceptions/MissingPropertyTest.php
diff --git a/tests/exceptions/UnknownMethodTest.php b/tests/exceptions/UnknownMethodTest.php
diff --git a/tests/exceptions/UnknownPropertyTest.php b/tests/exceptions/UnknownPropertyTest.php

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ class MissingPropertyException extends ConfigException`
`11`	`11`	`{`
`12`	`12`	`public function __construct(protected(set) ?string $property, ?string $message = null, array $config = [])`
`13`	`13`	`{`
`14`		`- parent::__construct($message ?? ($this->getName() . ": '$this->property'"), $config);`
	`14`	`+ parent::__construct($message ?? ($this->getName() . ": $this->property"), $config);`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class UnknownMethodException extends BadMethodCallException`
`14`	`14`	`public function __construct(protected(set) string $method, ?string $message = null)`
`15`	`15`	`{`
`16`	`16`	`$this->method = $method;`
`17`		`- parent::__construct($message ?? ($this->getName() . ": $this->method "));`
	`17`	`+ parent::__construct($message ?? ($this->getName() . ": $this->method"));`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`/**`