[AU-2523] codespaces devstack collision port 2000 for frontend-app-learning #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gurations due to codespace port conflict
papphelix
changed the title
robrap
reviewed
Jun 4, 2025
| @@ -31,7 +31,7 @@ Instead of a service name or list, you can also run commands like ``make dev.pro | |||
| +------------------------------------+-------------------------------------+----------------+--------------+ | |||
| | `frontend-app-learner-record`_ | http://localhost:1990/ | MFE (React.js) | Default | | |||
| +------------------------------------+-------------------------------------+----------------+--------------+ | |||
| | `frontend-app-learning`_ | http://localhost:2000/ | MFE (React.js) | Default | | |||
| | `frontend-app-learning`_ | http://localhost:2010/ | MFE (React.js) | Default | | |||
There was a problem hiding this comment.
I think we want a row with "Do not use. Reserved for Codespaces.", and http://localhost:2000/, to help ensure this doesn't happen again in the future.
There was a problem hiding this comment.
Added a row in rst table and added explanation on the same
…odespaces conflict
robrap
reviewed
Jun 5, 2025
|
|
||
| Some common service combinations include: | ||
|
|
||
| * ``lms``: LMS, along with dependencies ``forum``, ``discovery``, ``Authn`` and some databases | ||
| * ``ecommerce``: Ecommerce, but also LMS as a dependency (for auth) | ||
| * ``cms+credentials``: Services can be combined to affect both at once | ||
| * **Reserved for Codespace**: The port `2000` is being used for github Codespace service & reserverd for Codespace use only. |
There was a problem hiding this comment.
Suggested change
| * **Reserved for Codespace**: The port `2000` is being used for github Codespace service & reserverd for Codespace use only. | |
| * **Reserved for Codespace**: The port `2000` is being used for github Codespace service & reserved for Codespace use only. |
| @@ -1103,7 +1103,7 @@ services: | |||
| aliases: | |||
| - edx.devstack.frontend-app-learning | |||
| ports: | |||
| - "2000:2000" | |||
| - "2010:2000" # avoid Codespaces port 2000 conflict | |||
There was a problem hiding this comment.
I think this comment and the notes in the rst doc are probably enough. I do not think we need to document this conflict for every usage of http://localhost:2010. We'll get an additional opinion before deciding either way, but it will be important to decide before making changes across repos.
| @@ -18,7 +18,7 @@ | |||
| 'http://localhost:1991', # frontend-app-admin-portal | |||
| 'http://localhost:18400', # frontend-app-publisher | |||
| 'http://localhost:18450', # frontend-app-support-tools | |||
| 'http://localhost:2000', # frontend-app-learning | |||
| 'http://localhost:2010', # frontend-app-learning (port changed from 2000 to 2010, due to conflict in codepsace) | |||
There was a problem hiding this comment.
See earlier comment about whether or not we might drop all these redundant comment changes.
There was a problem hiding this comment.
- I got confirmation in Slack that we can remove these additional comments.
- Before this merges, we'll need to prep PRs for the following: https://github.com/search?q=org%3Aedx+localhost%3A2000++NOT+is%3Aarchived&type=code
- We'll also need a communication plan before we merge as well.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to github codespace mapping system port 2000 & had a collision with
make dev.upwe had to fix the ports forfrontend-app-learningfrontend-app-learningto 2010