From 3a386cb55d7536b1d962ae3c03370480c58def27 Mon Sep 17 00:00:00 2001 From: Rovanion Luckey Date: Mon, 19 Jun 2023 16:22:11 +0200 Subject: [PATCH] Remove instruction to use plaintext backend for storing GitHub tokens for Unit tests First of all, it is insecure to store passwords in plain text. It should be discuoraged, not instructed. Second, `keyring.backends.file.PlaintextKeyring` is no longer part of the keyring API as to discourage insecure storage of passwords. If the developer trying to set up the unit tests tries to follow these instructions verbatum they will fail with the following error: ``` Traceback (most recent call last): File "", line 1, in AttributeError: module 'keyring.backends' has no attribute 'file' ``` --- docs/unit-tests.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/unit-tests.md b/docs/unit-tests.md index c6d94d1921..5eb559c6c2 100644 --- a/docs/unit-tests.md +++ b/docs/unit-tests.md @@ -150,7 +150,6 @@ This can be done as follows (copy-paste the GitHub token at the `Password:` prom ``` console $ python >>> import getpass, keyring ->>> keyring.set_keyring(keyring.backends.file.PlaintextKeyring()) >>> keyring.set_password('github_token', 'easybuild_test', getpass.getpass()) Password: >>> exit()