Skip to content
This repository was archived by the owner on Aug 2, 2023. It is now read-only.

Merge/remote dev #125

Open
wants to merge 390 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
390 commits
Select commit Hold shift + click to select a range
7711820
Add Azure Key Vault on Ordering.API to validate this scenario
unaizorrilla Jul 16, 2018
8f5aa5c
fix classname of EventBus.Test models
NeilQ Jul 21, 2018
453a925
Merge pull request #675 from NeilQ/fix-eventbus-test-classname
CESARDELATORRE Jul 23, 2018
71780f4
Typo
RobinSoenen Jul 26, 2018
c7466df
Merge pull request #683 from RobinSoenen/patch-1
CESARDELATORRE Jul 26, 2018
c3983b3
Merge pull request #582 from i02coroj/fix-messages-lost
mvelosop Jul 26, 2018
0733df5
Funtional test failling because it didn't find appsettings path, assu…
mvelosop Jul 27, 2018
e7ac873
Merge branch 'fix/location-appsettings-path' into dev
mvelosop Jul 27, 2018
f06a2c5
Add missing Payment project.
mvelosop Jul 27, 2018
e1313f2
Merge branch 'fix/missing-payment.api-project' into dev
mvelosop Jul 27, 2018
b005b63
Add azure key vault support in all services
unaizorrilla Jul 31, 2018
3f225e4
Merge branch 'dev' of https://github.com/dotnet/eShopOnContainers int…
unaizorrilla Jul 31, 2018
5c06f6e
Fix issue 685
unaizorrilla Jul 31, 2018
5e4bade
Update with v1 of Serverless eBook
CESARDELATORRE Aug 2, 2018
e6eb5c1
Update with v1 of Serverless eBook
CESARDELATORRE Aug 2, 2018
e476899
Merge branch 'dev' of https://github.com/dotnet-architecture/eShopOnC…
CESARDELATORRE Aug 2, 2018
234f76f
Update with v1 of Serverless eBook
CESARDELATORRE Aug 2, 2018
ad47571
Fixes 401 after login in helm deployments
eiximenis Aug 2, 2018
fdf1d32
Merge pull request #693 from dotnet-architecture/401-helm
eiximenis Aug 2, 2018
fc031b1
Update serverless ebook minor issue
CESARDELATORRE Aug 2, 2018
a2bc8aa
Merge branch 'dev' of https://github.com/dotnet-architecture/eShopOnC…
CESARDELATORRE Aug 2, 2018
61a1078
Update minor issue for serverless ebook
CESARDELATORRE Aug 2, 2018
5347990
Merge pull request #653 from luk355/dev
mvelosop Aug 17, 2018
ce039b2
Updates to Microservices eBook to v2.1.02
CESARDELATORRE Aug 25, 2018
611023e
Updates to Microservices eBook to v2.1.02
CESARDELATORRE Aug 25, 2018
f7e2255
Updated WebSPA to Angular 6, Bootstrap 4, HttpClient and new rxjs
IvanFarkas Aug 29, 2018
77061fc
Updated WebSPA to Angular 6, Bootstrap 4, HttpClient and new rxjs
IvanFarkas Aug 29, 2018
c9d3354
Change to latest SDK version 2.1.401
VoodooSV Aug 29, 2018
0296735
Merge pull request #728 from VoodooSV/patch-1
CESARDELATORRE Aug 29, 2018
2a22ef7
Removed unused EventBusConnection property
07101994 Aug 30, 2018
f778b37
Adjusted file name to match class name
ivanbuhacb Sep 3, 2018
9f34b7e
fix: duplicated "using Seedwork;"
amedora Sep 7, 2018
4509153
Merge pull request #755 from amedora/dev
CESARDELATORRE Sep 7, 2018
a064795
Work on timeout on idsrv and mvc app
unaizorrilla Sep 7, 2018
28f7baa
Fixed error in namespace.
CESARDELATORRE Sep 7, 2018
09d7d09
Merge branch 'features/IdSrvTimeoutReview' into dev
unaizorrilla Sep 11, 2018
0904bdb
Reference class from .NET Core 2.1 instead of a copy.
PureKrome Sep 13, 2018
cd1bf5e
Create CONTRIBUTING.md
mvelosop Sep 13, 2018
7b41a2b
Fix test readme.md link
mvelosop Sep 13, 2018
11acb94
Merge pull request #768 from PureKrome/remove-redundant-background-ta…
CESARDELATORRE Sep 13, 2018
43c1580
Fixed bug #729
Sep 20, 2018
ccd11f0
Fixed bug #766 signalr
Sep 20, 2018
9d194ac
Added libman subset of necessary lib files in mvcapp
Sep 20, 2018
96cabfe
Removed bower in Identity.api service
Sep 21, 2018
ba093d1
#782 Fixed signalr not working in aks bug
Sep 25, 2018
822efa7
Updated Microservices eBook for eReaders (.MOBI and .EPUB) to v2.1.02
CESARDELATORRE Sep 25, 2018
1d6d9f7
Updated Microservices eBook for eReaders (.MOBI and .EPUB) to v2.1.02
CESARDELATORRE Sep 25, 2018
70d7cc9
Migrate WebMVC app to bootstrap 4
Sep 26, 2018
349d5ea
update swagger nuget to 2.4.0 from 3.0.0
erikpique Sep 27, 2018
a92c48e
Removed bower from WebStatus app
Sep 27, 2018
5745f54
Migrated Identity.api to Bootstrap 4
Sep 27, 2018
43695ca
Merge branch 'dev' of https://github.com/dotnet-architecture/eShopOnC…
Sep 27, 2018
ab4dde1
Merge pull request #788 from erikpique/dev
ramon-tomas-c Sep 27, 2018
c907155
Merge branch 'dev' into prng6
Sep 27, 2018
dc767eb
Fixed issue header not included in requests
Sep 28, 2018
1fdcc5c
MediatorR: Migration Guide 4.x to 5.0
erikpique Sep 28, 2018
ad76fa0
Fixed broken UI in SPA after migrating to Bootstrap 4
Sep 28, 2018
5fd5c6a
Delete eShopOnContainers.TestRunner.iOS.csproj.bak
say25 Sep 29, 2018
bb8dd63
Merge branch 'master' into dev
erikpique Oct 1, 2018
cdeaa30
Fixed issue webmvc signalr not notifying submitting state
Oct 1, 2018
0bf9a91
Merge remote-tracking branch 'origin/#782-Fix-SignalR-aks' into dev
Oct 1, 2018
7becb9d
✔ Typo fix "suittable" => "suitable"
burhandodhy Oct 1, 2018
b0090cc
Merge pull request #789 from erikpique/dev
ramon-tomas-c Oct 2, 2018
db35a5c
Initial approach
Oct 3, 2018
9adda02
Updated OrderingIntegrationEvent svc
Oct 3, 2018
535044e
Add private setters so deserializing on integration event handler wor…
mvelosop Oct 5, 2018
a9a9ddf
Merge pull request #797 from mvelosop/fix/725-address-value-object-no…
mvelosop Oct 5, 2018
6f9ee00
Merge pull request #730 from 07101994/dev
ramon-tomas-c Oct 5, 2018
adafb9a
Send commands for modifying state in IntegrationEventHandlers
Oct 8, 2018
6811112
[BUG] When subscribing more than 1 different event handlers for the s…
erikpique Oct 9, 2018
4e97166
[Bug] Deserialization of IntegrationEvent #667
erikpique Oct 9, 2018
f81ff0e
Corrected the grammatical and spelling mistakes on Readme.md
Oct 9, 2018
1178b83
Merge pull request #802 from dev-aritra/readmeCorrection
CESARDELATORRE Oct 9, 2018
641b732
[BUG] After explicit logout, hit on login, then it is automatically r…
erikpique Oct 10, 2018
74924d9
Token lifetime handling #118
erikpique Oct 11, 2018
24bed0a
Send IntegrationEvents after committing transactions
Oct 11, 2018
e3f8ac6
Refactoring IntegrationEventLog service
Oct 12, 2018
5aa855e
Fix method name in OnDisconnectAsync
libPhipp Oct 18, 2018
ed2c905
Improves README
manaswinidas Oct 31, 2018
70332ae
Merge pull request #836 from manaswinidas/dev
CESARDELATORRE Oct 31, 2018
976ef98
Added Architecture and presentation decks
CESARDELATORRE Nov 1, 2018
c0d496e
Merge pull request #1 from dotnet-architecture/dev
tthtun Nov 1, 2018
6c359f8
Fixed typo.
tthtun Nov 1, 2018
de6f9e6
Merge pull request #840 from tthtun/dev
CESARDELATORRE Nov 1, 2018
9b21ac1
Merge dev
Nov 12, 2018
9f5e7ae
Fixed ordering unit test
Nov 12, 2018
9775219
change netcore 2.1 to 2.2 and update nugets
erikpique Nov 12, 2018
2593d5d
local k8s docker support
eiximenis Nov 12, 2018
a26f97c
Merge branch 'k8s-docker' into dev
eiximenis Nov 12, 2018
4089460
Updated Ocelot version
Nov 13, 2018
7b10b57
Merge branch 'update-ocelot' into dev
Nov 13, 2018
574e07b
update dockerfiles
erikpique Nov 13, 2018
6aaa718
Merge branch 'dev' into feature/net22preview3
piqueterron Nov 13, 2018
e30fd3f
Merge pull request #850 from erikpique/feature/net22preview3
ramon-tomas-c Nov 13, 2018
4cb0e5c
Merge pull request #821 from erikpique/feature/626
ramon-tomas-c Nov 14, 2018
4f62175
Merge branch 'dev' into feature/118
ramon-tomas-c Nov 14, 2018
01f6feb
Merge pull request #820 from erikpique/feature/118
ramon-tomas-c Nov 14, 2018
06de1b6
Merge pull request #819 from erikpique/feature/667
ramon-tomas-c Nov 14, 2018
7fc68b4
Merge pull request #818 from erikpique/feature/645
ramon-tomas-c Nov 14, 2018
deb3d38
add features api
erikpique Nov 14, 2018
b8969e6
standar names and fixed response for swagger apis
erikpique Nov 15, 2018
e410b8d
Refactoring Buyer aggregate
Nov 19, 2018
8cdfbfb
add test to CI
erikpique Nov 20, 2018
06e641a
Merge pull request #851 from erikpique/feature/60697
ramon-tomas-c Nov 26, 2018
f7cb344
Merge pull request #861 from erikpique/feature/58388
ramon-tomas-c Nov 27, 2018
3011c82
Fixed hardcoded redis connection in FunctionalTests
Nov 27, 2018
038ea19
get rid of flatmap-stream
eiximenis Nov 28, 2018
c68eed6
udpated npm-watch
eiximenis Nov 28, 2018
73412e2
update test deploy
erikpique Nov 29, 2018
3ddbdd6
Updated eBook (pdf) to v2.1.03
nishanil Nov 30, 2018
0f6f4e6
Integrate HealthCheck to all eShop services and apps
Nov 30, 2018
f76d1a6
Merge pull request #865 from erikpique/feature/58388
ramon-tomas-c Dec 3, 2018
8d794a2
Updated Helm scripts to include healthcheck url env vars
Dec 4, 2018
25bef6d
Updated Webstatus startup
Dec 4, 2018
eda8a6e
Fixed rxjs version in package.json
Dec 5, 2018
82bda5c
Updated tests
Dec 5, 2018
766fc40
Merge branch 'ci-build' into dev
Dec 5, 2018
ffca2da
Migrated to netcore 2.2
Dec 11, 2018
fa0b1a7
Added serilog
Dec 13, 2018
b408d58
fix error on aks deployment
eiximenis Dec 17, 2018
dbf175f
Fixed missing env variables in marketing.api in k8s scripts
Jan 3, 2019
b9dcc80
Merge Netcore2.2 branch
Jan 3, 2019
a387f21
fixed merge
Jan 3, 2019
873d70a
Fixed netcore2.2 CORS issue not allowing wildcard origins
Jan 4, 2019
8c6068c
Updated ReadMe to include .NET 2.2 updates
nishanil Jan 7, 2019
6450cab
Updated eBook to 2.2
nishanil Jan 9, 2019
86c36c9
Fixed type in HttpGlobalExceptionFilter
Jan 9, 2019
d70e233
Fixed a minor Typo in the eBook.
nishanil Jan 10, 2019
0099b1d
Update README.md
CESARDELATORRE Jan 10, 2019
a8b705f
Update README.md
CESARDELATORRE Jan 10, 2019
81f2ed4
deleted global.json
eiximenis Jan 14, 2019
8677b8d
Webhooks API: WIP - Initial commit
eiximenis Jan 16, 2019
6c094c6
Publish eReader Formats
nishanil Jan 17, 2019
e3daacb
Updated v2.2 book eReader formats
nishanil Jan 17, 2019
586c6de
WIP Webhooks
eiximenis Jan 21, 2019
485bb9e
WIP
eiximenis Jan 23, 2019
38243a9
comment updated in compose
eiximenis Jan 24, 2019
2c5f58f
healtchecks
eiximenis Jan 29, 2019
8a31efe
badge for buid status
eiximenis Jan 29, 2019
a4f169d
added port configuration for liveness/readiness probes in helm charts
eiximenis Jan 29, 2019
e759459
updated helm charts for final probes config on k8s
eiximenis Jan 29, 2019
9b0eadd
webhooks API & client
eiximenis Jan 29, 2019
4d6b2f0
Add Serilog and Seq working in Docker
mvelosop Jan 31, 2019
7cd717c
Add integration event traces
mvelosop Jan 31, 2019
d6aee2c
Remove MachineName from logger configuration, not really useful for e…
mvelosop Jan 31, 2019
6d2c1fc
Use structured logging for exceptions
mvelosop Jan 31, 2019
3a22e2f
Add Seq as sink and some integration event traces
mvelosop Jan 31, 2019
d83fa3b
Standarize log message
mvelosop Jan 31, 2019
e05a876
Merge pull request #791 from burhandodhy/patch-1
mvelosop Feb 4, 2019
50a5f8b
new helm charts for webhooks
eiximenis Feb 6, 2019
8de902c
Add Seq to Ordering.API
mvelosop Feb 6, 2019
24b660f
Expore Program.AppName/AppShortName for logging
mvelosop Feb 6, 2019
b9839d1
Added traces for UserCheckoutAcceptedIntegrationEvent
mvelosop Feb 6, 2019
423066a
Add log traces for integration event handling
mvelosop Feb 6, 2019
5b237b0
webhooks flow finished. Only missing bug in api that don't show the h…
eiximenis Feb 6, 2019
f3cd373
Add logging to CreateOrderCommandHandler
mvelosop Feb 6, 2019
29c41fe
Remove specific version for Microsoft.AspNetCore.App
mvelosop Feb 6, 2019
8a602a1
Added ApiGateways to solution mimicking eShopOnContainers-ServicesAnd…
MattMinke Feb 7, 2019
adbe31b
AllowedCorsOrigins disabled for Xamarin client. Fixes #905
Feb 11, 2019
71e3839
webhooks finished
eiximenis Feb 11, 2019
dc36826
forcing granturl to be in same origin as hook url
eiximenis Feb 11, 2019
0eae3c3
Merge branch 'features/webhooks' into dev
eiximenis Feb 11, 2019
031de21
typo
SychevIgor Feb 13, 2019
71bcc08
.gitignore site.*.js files, as the are created on opening the Project
mvelosop Feb 15, 2019
40e3722
Rename BuyerEntityTYpeConfiguration.cs to BuyerEntityTypeConfiguratio…
Feb 15, 2019
01033a7
Added Seq to Identity.API
mvelosop Feb 18, 2019
f7c6853
Added Seq to Locations.API
mvelosop Feb 18, 2019
ca02053
Added Seq to Marketing.API
mvelosop Feb 18, 2019
71d75f8
Add Seq to Payment.API
mvelosop Feb 18, 2019
37409e8
Add Seq to WebStatus
mvelosop Feb 18, 2019
21427eb
Add Seq to ApiGatewayAggregators
mvelosop Feb 18, 2019
6ccd7b6
Ass Seq to SignalR.Hub
mvelosop Feb 18, 2019
122fab5
Add LogContext to IntegrationEventHandlers
mvelosop Feb 18, 2019
da72fc8
Revert "Add Seq to ApiGatewayAggregators"
mvelosop Feb 18, 2019
ec8add2
Adding logger to unit test
mvelosop Feb 18, 2019
2158938
Fix IntegrationEventIdContext logging property name
mvelosop Feb 18, 2019
9d7124b
Exclude generated files in solution .gtignore
mvelosop Feb 18, 2019
77debf8
Add Seq to WebMVC
mvelosop Feb 20, 2019
12148c9
Refactor LogContext for IntegrationEvent Handlers to include AppName
mvelosop Feb 21, 2019
ad7b332
Add log traces for commands
mvelosop Feb 21, 2019
e6d1318
Add LogContext for behaviour transacction
mvelosop Feb 21, 2019
f42f29d
Ensure transaction is committed in the correct context, when handling…
mvelosop Feb 21, 2019
cda590e
Add Seq to ordering.backgroundtasks
mvelosop Feb 21, 2019
405e5be
Add publishing integration events traces
mvelosop Feb 21, 2019
dfc680e
Fix naming inconsistency
mvelosop Feb 21, 2019
2713ea3
Include files rebuilt by bundling and minification upon opening VS
mvelosop Feb 21, 2019
b2d7f8b
Merge pull request #944 from mvelosop/fix/changed-js-files-webmvc-pro…
mvelosop Feb 21, 2019
63a325e
Fix non-structured traces
mvelosop Feb 22, 2019
7dbab01
Update traces templates
mvelosop Feb 22, 2019
185a5dc
minor packages update
Feb 19, 2019
5b36a89
replace loggerFactory.AddConsole(); with loggerBuilder.AddConsole();
Feb 26, 2019
38a86f1
General refactoring for documentation
mvelosop Feb 26, 2019
b6b0744
Standarize ApplicationContext logging property
mvelosop Feb 26, 2019
e98c625
runfix
Feb 28, 2019
19f4478
Merge pull request #942 from SychevIgor/dev
mvelosop Feb 28, 2019
c1d7ca8
Merge branch 'dev' into features/add-seq-sink
mvelosop Feb 28, 2019
ec4fb3c
Fix css 404 on logging in
mvelosop Feb 28, 2019
23992ed
Merge pull request #952 from dotnet-architecture/features/add-seq-sink
mvelosop Feb 28, 2019
0105808
Remove unused external logins classes
mvelosop Mar 1, 2019
c92c8c2
Merge pull request #953 from dotnet-architecture/fix/remove-unused-so…
mvelosop Mar 1, 2019
2717659
Refactor ModelDTOs for a more consistent folder structure
mvelosop Mar 4, 2019
f9388c5
Merge pull request #954 from dotnet-architecture/refactor/model-dtos
mvelosop Mar 4, 2019
76e1072
Add logging of subscription events
mvelosop Mar 4, 2019
04e594f
Merge pull request #955 from dotnet-architecture/enhancement/improve-…
mvelosop Mar 4, 2019
d6e8a98
Fix duplicate x-requestid headers
mvelosop Mar 4, 2019
13ecdfd
Merge pull request #956 from dotnet-architecture/fix/708-duplicate-x-…
mvelosop Mar 4, 2019
c19e188
Fix JSON structure error.
mvelosop Mar 5, 2019
3a26761
Merge pull request #957 from dotnet-architecture/fix/broken-appsettings
mvelosop Mar 5, 2019
461c162
Fix bad previous fix
mvelosop Mar 5, 2019
b3477e6
Merge pull request #958 from dotnet-architecture/fix/repair-bad-broke…
mvelosop Mar 5, 2019
1219f89
Merge pull request #899 from davidhenley/patch-1
mvelosop Mar 5, 2019
34056e0
Merge pull request #825 from libPhipp/RemoveFromGroupAsync
mvelosop Mar 5, 2019
bf57c55
Merge pull request #790 from say25/patch-1
mvelosop Mar 5, 2019
2ecc867
Merge pull request #856 from denjamal/Refactoring
mvelosop Mar 5, 2019
3485241
Merge pull request #939 from jsantanders/patch-1
mvelosop Mar 5, 2019
0bd1884
Merge pull request #937 from SychevIgor/SychevIgor-patch-1
mvelosop Mar 5, 2019
e2d5ccb
Restored original name
skill-bit Mar 5, 2019
bbbbdf5
Merge pull request #1 from dotnet-architecture/dev
skill-bit Mar 5, 2019
de8db69
Updated file names to match class and interface names.
skill-bit Mar 5, 2019
0ea7c22
Rename orderStatusChangedToAwaitingValidationIntegrationEventHandler.…
sheng-jie Mar 6, 2019
2f096ee
Merge pull request #960 from sheng-jie/patch-4
mvelosop Mar 6, 2019
8d97f33
Merge pull request #746 from ivanbuha/dev
mvelosop Mar 6, 2019
12dd285
host don't need anymore
Mar 10, 2019
9c37df1
Critical vulnerabilities solved
mvelosop Mar 12, 2019
9720b4c
Update JS packages to new versions without know vulnerabilities;
mvelosop Mar 12, 2019
942fcdf
Merge pull request #968 from dotnet-architecture/fix/npm-reported-vul…
mvelosop Mar 12, 2019
197d044
Merge pull request #966 from SychevIgor/igorsychev/host
mvelosop Mar 14, 2019
5c2b145
Commented out local configuration, to avoid exception
mvelosop Mar 14, 2019
86b4b76
Merge pull request #935 from Minx-SigEp/dev
mvelosop Mar 14, 2019
d5adb5f
Update HealthChecks UI libraries to properly handle missing services.
mvelosop Mar 18, 2019
b439352
Merge pull request #974 from mvelosop/fix/health-check-report-collect…
mvelosop Mar 18, 2019
a30d80a
scripts fot catalog
eiximenis Mar 19, 2019
8b38150
updated build catalog
eiximenis Mar 19, 2019
b075a4d
updated build catalog 2
eiximenis Mar 19, 2019
c81ae16
new yaml files
eiximenis Mar 19, 2019
c978bf3
builds readme
eiximenis Mar 19, 2019
9d41288
Update azure-pipelines.yml for Azure Pipelines
eiximenis Mar 19, 2019
97c4efc
Update azure-pipelines.yml for Azure Pipelines
eiximenis Mar 19, 2019
57fd8ac
builds updated
eiximenis Mar 19, 2019
0a3eaa5
Merge branch 'vsts-yaml-builds' of https://github.com/dotnet-architec…
eiximenis Mar 19, 2019
c7b4fe4
updated builds to use git branch name
eiximenis Mar 20, 2019
94ff3fa
Updated readme.md for builds info
eiximenis Mar 20, 2019
3d0aae8
webhooks.client rebranded
eiximenis Mar 21, 2019
713eb27
adding triggers to yaml builds
eiximenis Mar 21, 2019
a190952
Fixed NPM Issues and nuget packages
Mar 21, 2019
65b7b31
Done Updating versions
Mar 21, 2019
f7d9fc9
Merge branch 'dev' into features/UpgradePackageVersions
Mar 21, 2019
d2bc197
done merge
Mar 25, 2019
5c579dc
WIP
Mar 25, 2019
0a044b1
Fix Merge conficts and fix errors on apps startups
Mar 27, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 1 addition & 4 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@ cli-linux
**/obj/
**/node_modules/
**/bower_components/
**/wwwroot/lib/
!src/Web/WebDashboardRazor/wwwroot/lib/
!**/wwwroot/lib/signalr/*
!**/wwwroot/lib/toastr/*
**/wwwroot/lib/*
global.json
**/appsettings.localhost.json
src/Web/WebSPA/wwwroot/
7 changes: 7 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ bld/

# Visual Studio 2015 cache/options directory
.vs/

# .js files created on build:
src/Web/WebMVC/wwwroot/js/site*

# Uncomment if you have tasks that create the project's static files in wwwroot
**/wwwroot/lib/
!/wwwroot/lib/signalr
Expand Down Expand Up @@ -268,3 +272,6 @@ src/Services/Catalog/Catalog.API/Setup/CatalogItemsAI.zip
cli/
/workbench/__pycache__
.mfractor

# Ignore HealthCheckdb
*healthchecksdb*
67 changes: 67 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
# How to contribute to eShopOnContainers

This repo is a reference and learning resource and everyone is invited to contribute, however not all PRs will be accepted into the main branch (**`dev`**).

There's a general development strategy that's driven by @CESARDELATORRE, who chooses, or defines criteria for choosing, the issues to include in the codebase, given a bunch of constraints and other guidelines.

However you can always get in touch with him, if you want to implement some general-interest feature in your repo and have it referenced from the [documentation](https://docs.microsoft.com/dotnet/standard/microservices-architecture/) or the [Microservices eBook](https://aka.ms/microservicesebook/).

## Coding Standards

There are no explicit coding standards so pay attention to the general coding style, that's (mostly) used everywhere.

However, there's only one **REALLY** important rule: **use spaces for indenting** 😉.

## Development Process

In order to help manage community contributions and avoid conflicts, there's a [Development project](https://github.com/dotnet-architecture/eShopOnContainers/projects/3) in this repo, to track assignments to any significant development effort.

Great but... **what's "significant"**?

That's not too easy to define and there are no clear criteria right now but, probably, changing "a couple" lines of code in one file would not qualify while changing "a bunch" of files would.

We'll all be learning in the process so we'll figure it out somehow.

### General Steps

1. Issues are managed as usual with the regular issues list, just like any other repo.

2. Once an issue is marked as a bug, enhancement, new feature or whatever needs development work, it will be labeled as a **backlog-item** and included as the last item in the Backlog project column.

3. Community members can propose themselves to code an issue.

4. @CESARDELATORRE/collaborators will prioritize the backlog items and arrange them in the **Backlog** column, so that the items in the top of the list are implemented first.

5. @CESARDELATORRE/collaborators will review the issues and select the ones approved to begin development with, and move them to the **Approved** column.

6. Issues in the **Approved** column can be assigned to a **collaborator** or to a **community member** who would then begin working on the issue and submit a PR as usual.

## Tests

There's not a tests policy in the project at this moment, but it'll be greatly appreciated if you include them within the [updated test structure](./test/readme.md).

## Forks and Branches

All contributions must be submitted as a [Pull Request (PR)](https://help.github.com/articles/about-pull-requests/) so you need to [fork this repo](https://help.github.com/articles/fork-a-repo/) on your GitHub account.

The main branches are **`dev`** and **`master`**:

- **`dev`**: Contains the latest code **and it is the branch actively developed**.
**All PRs must be against `dev` branch to be considered**. This branch is developed using .NET Core 2.x

- **`master`**: Synced from time to time from **`dev`**. It contains "stable" code.
(**Keep in mind "stable" does not mean PRODUCTION-READY!**)

- Any other branch is considered temporary and could be deleted at any time. Do not submit any PR to them!

## DISCLAIMER - This is not a PRODUCTION-READY TEMPLATE for microservices
eShopOnContainers is a reference application to **showcase architectural patterns** for developing microservices applications on .NET Core. **IT IS NOT A PRODUCTION-READY TEMPLATE** to start real-world application. In fact, the application is in a **permanent beta state**, as it’s also used to test new potentially interesting technologies as they show up.

Since this is a learning resource, some design decisions have favored simplicity to convey a pattern, over production-grade robustness.

## Suggestions

We hope this helps us all to work better and avoid some of the problems/frustrations of working in such a large community.

We'd also appreciate any comments or ideas to improve this.

4 changes: 3 additions & 1 deletion NuGet.config
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
<add key="repositoryPath" value="packages" />
</config>
<packageSources>
<add key="nuget" value="https://api.nuget.org/v3/index.json" />
<add key="Preview-aspnetcore-tools" value="https://dotnet.myget.org/F/aspnetcore-tools/api/v3/index.json"/>
<add key="Preview-aspnetcore-dev" value="https://dotnet.myget.org/F/aspnetcore-dev/api/v3/index.json"/>
<add key="Preview-aspnetcore" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json"/>
<add key="AspNetCore" value="https://dotnet.myget.org/F/aspnet-feb2017-patch/api/v3/index.json" />
<add key="corefxlab" value="https://dotnet.myget.org/F/dotnet-corefxlab/api/v3/index.json" />
<add key="cli-deps" value="https://dotnet.myget.org/F/cli-deps/api/v3/index.json" />
Expand Down
Loading