Skip to content

Commit 8d1a436

Browse files
9and3DamienGilliardeleniv3d
authored
Fixes from IBOIS's dry run (#131)
* FIX: avoiding error for default drop-on-canvas component assembly * FIX: no default canvas drop error * FIX: canvas drop error * ADD: CONTRIBUTING.md that had been erroneously deleted some time ago * ADD: CONTRIBUTING.md that had been erroneously deleted some time ago [skip ci] * FIX: canvas drop error again * FIX: removing contributing * FIX: to problematic none catch for canvas drop error * FIX: sensitivity of joint detector to planar faces in roundwood case [skip ci] * FIX: no canvas error drop * FIX: joint preview for single beams * FIX: no arrow for single beam * ADD: new mean value for the compute and viz error components and csv export * UPDATE-FIX: assembly joint faces meshes in the same order as pc segments * FIX: joint segmentator always looking for planar segments (not roundwood) * FIX: segmentation returns empty segment if no corresp. seg. found * FIX: none values for unassociated joint faces are well handled * FIX: error estimation deals with none values in the evaluation of the etrema * FIX: n_joint is an integer, not a list [skip ci] * ADD: new enum to catch joint with missing points or too far * ADD: docstrings for new enum * FIX: typo in name * FIX: bug for missing dataclass due to order of appearance * WIP-UPDATE: add support for enum DFInvalidScanElement in DF_joint_segmentator * FIX: SetUserString instead of enum use for pointcloud flags * ADD: metadata for i_joint_displacement_tolerance parameter * FIX: give to joint face pointclouds the same UserString as the joint they are a part of * FIX Normal Segmentator and Colorize Cloud don't go red when dropped on canvas * REFACTOR-FIX: added the missing clouds and too far joint detection for the computation of error * FIX: working mesh visual for error * FIX: adaptation for log anaylsis * ADD: example files * WIP: started working on tutorial docs * FIX-WIP: temporary attempt to avoid assembly segmentator from breaking computing error comp * WIP-FLASH: temporary save for documentation on subtractive * FIX: face order for per-face analysis in DFCloudMeshDistance component corrected * FIX: correct export of joint labelling * ADD-CAP: tutorial for subtractive * ADD-CAP: added the log section to subtractive tutorial * FIX: preview assembly solved for logs --------- Co-authored-by: DamienGilliard <127743632+DamienGilliard@users.noreply.github.com> Co-authored-by: eleniv3d <43600924+eleniv3d@users.noreply.github.com>
1 parent 18fc934 commit 8d1a436

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+630
-268
lines changed
43.7 MB
Binary file not shown.
91.6 MB
Binary file not shown.
Binary file not shown.
Loading
Loading
Loading
Loading
556 KB
Loading
1.42 MB
Loading
Loading

0 commit comments

Comments
 (0)