Skip to content

fix: OpenShift integration test failures #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Jul 14, 2025

Description of Changes

Fixes the ginkgo not found and other go failures by adding -mod=readonly to all ginkgo and go commands to ensure -mod=vendor is never set for go modules without a vendor directory.

Additional Fixes

  • Pinned go stack versions to starter project tags that match the stack version number to address go version mismatching

Related Issue(s)

resolves devfile/api#1737

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • Test automation

Does this repository's tests pass with your changes?

  • Documentation

Does any documentation need to be updated with your changes?

  • Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron requested a review from a team as a code owner July 14, 2025 19:12
@openshift-ci openshift-ci bot requested review from johnmcollier and thepetk July 14, 2025 19:13
@michael-valdron
Copy link
Member Author

Ignoring EC failure as the fix is blocked by this issue.

@michael-valdron
Copy link
Member Author

Hmmm.. this might need further investigation into what is going on, this change did fix this problem in my local testing using the openshift release image 😕

I'll put this PR in WIP for now.

@michael-valdron
Copy link
Member Author

Can reproduce error in latest fail under a local pull of the runner image:

+ go install github.com/onsi/ginkgo/v2/ginkgo@v2.19.0
go: github.com/onsi/ginkgo/v2/ginkgo@v2.19.0: cannot query module due to -mod=vendor

When I add -mod=readonly also to go install the problem is resolved:

+ go install -mod=readonly github.com/onsi/ginkgo/v2/ginkgo@v2.19.0
go: downloading github.com/onsi/ginkgo/v2 v2.19.0
go: downloading golang.org/x/tools v0.21.0
go: downloading github.com/go-task/slim-sprig/v3 v3.0.0
go: downloading github.com/google/pprof v0.0.0-20240424215950-a892ee059fd6

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron marked this pull request as ready for review July 15, 2025 05:35
@openshift-ci openshift-ci bot requested a review from Jdubrick July 15, 2025 05:35
@michael-valdron michael-valdron changed the title fix: Add -mod=readonly to ginkgo version fetch [WIP]fix: Add -mod=readonly to ginkgo version fetch and go install Jul 15, 2025
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron changed the title [WIP]fix: Add -mod=readonly to ginkgo version fetch and go install [WIP]fix: Add -mod=readonly to ginkgo and go commands Jul 15, 2025
@michael-valdron
Copy link
Member Author

/retest

2 similar comments
@michael-valdron
Copy link
Member Author

/retest

@michael-valdron
Copy link
Member Author

/retest

@michael-valdron
Copy link
Member Author

Examining the test log at the point of timeout, it looks like we need to reduce our stack versions being tested on.

@michael-valdron
Copy link
Member Author

Discovered non terminating issue with the Go stack starter project, waiting to revert recent changes: devfile-samples/devfile-stack-go#3

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron requested a review from a team as a code owner July 16, 2025 22:34
@michael-valdron
Copy link
Member Author

Discovered non terminating issue with the Go stack starter project, waiting to revert recent changes: devfile-samples/devfile-stack-go#3

Have instead decided to pin go stack versions to use stack version tags to fetch the proper revision of the starter project: e8df390

@michael-valdron michael-valdron changed the title [WIP]fix: Add -mod=readonly to ginkgo and go commands [WIP]fix: OpenShift integration test failures Jul 17, 2025
@michael-valdron michael-valdron changed the title [WIP]fix: OpenShift integration test failures fix: OpenShift integration test failures Jul 17, 2025
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jul 17, 2025
Copy link

openshift-ci bot commented Jul 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit ee0685a into devfile:main Jul 17, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community devfile registry integration testing is failing due to missing ginkgo
2 participants