Description
Is there an existing issue for this?
- I checked and did not find my issue in the already reported ones
Describe the bug
Current status:
The possibility of visualizing a mask by the yellow overlay is coupled with the availability of mask refinements (feathering, blurring, etc.). The “display mask” button in the “blend mask” section of the module is also only available in this case.
For all modules before “demosaic”, for example “hot pixels”, the mask refinement is not possible for understandable reasons and therefore the "display mask" button is not available.
What makes the situation irritating (see https://discuss.pixls.us/t/mask-hot-pixel-usage/50669) is the fact that the modules always have an additional “display mask” button in the module header, even if no yellow overlay can be displayed due to the position of the module in the pixel pipe for the reason mentioned above.
Steps to reproduce
- goto darkroom
- activate any module located before "demosaic" in the pixelpipe allowing drawn masks, for example "hot pixels"
- create a drawn mask for this module
- click the "display mask" button in the modules header
- see the image shown in grayscale (OK) without the yellow overlay showing the used shape (irritating)
The most elegant solution to avoid irritation:
Enable the display of a yellow mask overlay also for the modules before "demosaic" in the pixelpipe. However, I suspect that there are well-defined reasons why this might not be possible (or extremely complex). Hence the
Suggestion for improvement:
Set the "display mask" button in the module header visible but disabled when a (drawn) mask is present in a module before "demosaic".
- The visibility of the button signals the presence of a mask to the user
- The "disabled" state indicates that a yellow overlay as a visualization of the mask cannot be displayed in this case.
Expected behavior
see above
Logfile | Screenshot | Screencast
No response
Commit
No response
Where did you obtain darktable from?
self compiled
darktable version
current master
What OS are you using?
Linux
What is the version of your OS?
Ubuntu 24.04
Describe your system
Of no importance here
Are you using OpenCL GPU in darktable?
Yes
If yes, what is the GPU card and driver?
No response
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
No response