metadata editor preset: shortcut and lua command do not work

[UliGesing]

Is there an existing issue for this?

• I checked and did not find my issue in the already reported ones

Describe the bug

I am trying to set a creative common license via meta data editor. Neither lua command nor keyboard shortcut work.

I tried this lua command, as copied from shortcut editor:
dt.gui.action("lib/metadata/preset/CC BY-NC-SA", 1,000)

After that, my logfile contains this error message:
[dt_action_process] action 'lib/metadata/preset/CC BY-NC-SA' not valid for current view

I tried to create a keyboard shortcut, but I get a popup message "... not assigned".

@wpferguson , @dterrahe : Could this have something to do with the new hierarchical presets? See #18829

Steps to reproduce

dt.gui.action("lib/metadata/preset/CC BY-NC-SA", 1,000)

After that, my logfile contains this error message:
[dt_action_process] action 'lib/metadata/preset/CC BY-NC-SA' not valid for current view

Expected behavior

No response

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

dt5.1.0+930~ga836f2f1f1

What OS are you using?

Linux

What is the version of your OS?

Arch-based EndeavorOs, rolling release

Describe your system

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

[dterrahe]

Since #17425 you can add the metadata editor to the darkroom, but shortcuts/lua dt.gui.action are only supported for the views where modules exist by default. This is because conflicts between shortcuts are checked at load time and enabling a module in a view where other conflicting shortcuts already exist would need one or the other to be deleted. The check in dt.gui.action could probably be relaxed to allow any module that could be enabled in a view.

[UliGesing]

Hi @dterrahe , thanks for this information.

This is fine for me.

I've switched to dt.gui.views.darkroom.display_image().creator and .rights – so no further changes are necessary here.

One addition: When I set these two properties from Lua, the display in the metadata editor and image information isn't updated. The display is only updated after the image is reloaded into Darkroom.

[wpferguson]

@UliGesing could you apply the metadata before you load the image into darkroom?

Updating the image fields directly doesn't cause a refresh of the image data because it was meant for use in lighttable where as soon as you moused over the image you would see the updated info.

[UliGesing]

@wpferguson , thank you for this hint. The script runs in darkroom, it applies some settings to the currently loaded image. Therefore using lighttable view does not help.

For me, it's not a perfect design, but it is no work blocker. If you want, we can close this issue. Or you take it into account during the December release.

[wpferguson]

We'll leave it open for now and I'll think about it for awhile...