[FR] Fixed position proposal for the styles preview in the lighttable.

[difrkaguilar]

Is your feature request related to a problem? Please describe.

Looking at the recent addition of the styles preview in the styles module of the lighttable, great BTW, I saw that the preview pop-up changes size depending on the number of modules applied to the image development that have been added as a style. The pop-up size changes back and forth indifferently showing these modules and the name of the style is repeated in the list and in the preview.

Describe the solution you'd like

It would be good to achieve greater consistency in the preview of the styles, to have fixed the position of this preview, where what changes is the image horizontally or vertically and use the icon already recognized by users to show the number of modules applied as part of the style, this icon is present both in the lighttable view and in the previews of the culling layout. Only if users place the mouse pointer over the icon, the pop-up menu will be displayed.

In that case it won't be necessary to repeat the style name as it is now in the pop-up and the preview will be resizable using the Ctrl+scroll shortcut as the graphs in curves or filmic.

Of course, it would be necessary to find another solution to the preview of the styles in the darkroom, since the same thing happens there, the pop-up menu shows the styles, and the window changes sizes with their corresponding modules applied and saved as styles.

reference images

icon used in the culling layout with the popup menu.

mockup proposal

version with fixed 1x1 box with the image inside in horizontal or vertical position and the icon to show the used modules in the current selected style.

version with image taking the biggest area possible in horizontal or vertical position and the icon to show the used modules in the current selected style.

@TurboGit @Nilvus PS. Sorry for my useless English. :-)

[TurboGit]

I'll be more in favor of keep this as a tooltip to avoid loosing too much vertical space on the style module. But I don't know how to position a tooltip in absolute coordinate to have it always at the same place. Then, we could add the image before the module list to ensure the image will always be at the same place.

If a Gtk expert read that, can you please look at this or give pointers to how position a tooltip Window?

[TurboGit]

@dterrahe : Maybe you know how to do that?

[TurboGit]

@AlicVB : You are also a good candidate to help here. Maybe reworking as a popup?

[dterrahe]

I haven't looked at this yet, sorry. I will later this afternoon.

[AlicVB]

yep, popup can be a solution to finetune the position, but not for the size. But tbh, the size will differ in any case and I'm not sure it's worth the pain to handle this...
For me the current situation is completely ok. The fact that what we show is a tooltip is perfectly clear, and user may be used to the fact that tooltips window sizes change depending of its content.
What may (or not) be in favor of a popup is more that this will allow to show the window without any delay...

btw, I agree with @TurboGit about the "precious" vertical size (that plus the fact that this won't be possible to achieve same UI in darkroom)

[dterrahe]

popup can be a solution to finetune the position

agreed (popover)

but not for the size

Why not?

[AlicVB]

but not for the size

Why not?

because we can't know in advance the nb of line of the style history... so the height at least will change for each style (or I may have misunderstood something)

[dterrahe]

I thought we were talking about the size of the preview image?

So I guess the problem is in the light table if we anchor the popover to the module (header or somewhere) it might go up or down depending on how much space it needs and is available. Whereas in the darkroom, we anchor it to the button which is at the bottom so it will always (?) go up, so we put the image at the bottom of the popover so it doesn't have to move no matter how many lines are above it).