Special care for post-pipescale modules

Make sure those modules snap to demosaicer patterns for roi_in->x/y

Author: jenshannoschwalm

src/iop/ashift.c

@@ -1278,10 +1278,20 @@ void modify_roi_in(dt_iop_module_t *self,
   roi_in->width   = xM + iw2 - xm + 1.0f;
   roi_in->height  = yM + iw2 - ym + 1.0f;
 
+  const uint32_t filters = piece->pipe->dsc.filters;
+  if(piece->pipe->pipescale_order > self->iop_order && filters)
+  {
+    dt_print(DT_DEBUG_PIPE, "detected pipescale (%d) after %s (%d)", piece->pipe->pipescale_order, self->so->op, self->iop_order);
+    const int snap = filters == 9u ? 3 : 2;
+    roi_in->x = (roi_in->x / snap) * snap;
+    roi_in->y = (roi_in->y / snap) * snap;
+  }
+
 
   // sanity check.
   roi_in->x       = CLAMP(roi_in->x, 0, (int)floorf(orig_w));
   roi_in->y       = CLAMP(roi_in->y, 0, (int)floorf(orig_h));
+
   roi_in->width   = CLAMP(roi_in->width, 4, (int)floorf(orig_w) - roi_in->x);
   roi_in->height  = CLAMP(roi_in->height, 4, (int)floorf(orig_h) - roi_in->y);
 }

src/iop/crop.c

@@ -441,7 +441,14 @@ void modify_roi_in(dt_iop_module_t *self,
 
   roi_in->x += iw * d->cx;
   roi_in->y += ih * d->cy;
-
+  const uint32_t filters = piece->pipe->dsc.filters;
+  if(piece->pipe->pipescale_order > self->iop_order && filters)
+  {
+    dt_print(DT_DEBUG_PIPE, "detected pipescale (%d) after %s (%d)", piece->pipe->pipescale_order, self->so->op, self->iop_order);
+    const int snap = filters == 9u ? 3 : 2;
+    roi_in->x = (roi_in->x / snap) * snap;
+    roi_in->y = (roi_in->y / snap) * snap;
+  }
   roi_in->x = CLAMP(roi_in->x, 0, (int)floorf(iw));
   roi_in->y = CLAMP(roi_in->y, 0, (int)floorf(ih));
 }

src/iop/enlargecanvas.c

@@ -173,6 +173,14 @@ void modify_roi_in(dt_iop_module_t *self,
   // don't request outside image (no px for borders)
   roi_in->x = MAX(roundf(roi_out->x - border_size_l), 0);
   roi_in->y = MAX(roundf(roi_out->y - border_size_t), 0);
+  const uint32_t filters = piece->pipe->dsc.filters;
+  if(piece->pipe->pipescale_order > self->iop_order && filters)
+  {
+    dt_print(DT_DEBUG_PIPE, "detected pipescale (%d) after %s (%d)", piece->pipe->pipescale_order, self->so->op, self->iop_order);
+    const int snap = filters == 9u ? 3 : 2;
+    roi_in->x = (roi_in->x / snap) * snap;
+    roi_in->y = (roi_in->y / snap) * snap;
+  }
 
   // subtract upper left border from dimensions
   roi_in->width -= MAX(roundf(border_size_l - roi_out->x), 0);

src/iop/lens.cc

@@ -3223,6 +3223,12 @@ void modify_roi_in(dt_iop_module_t *self,
                    dt_iop_roi_t *roi_in)
 {
   dt_iop_lens_data_t *d = (dt_iop_lens_data_t *)piece->data;
+  if(piece->pipe->pipescale_order > self->iop_order)
+  {
+    *roi_in = *roi_out;
+    dt_print(DT_DEBUG_PIPE, "detected pipescale (%d) after %s (%d)", piece->pipe->pipescale_order, self->so->op, self->iop_order);
+    return;
+  }
 
   if(d->method == DT_IOP_LENS_METHOD_LENSFUN)
   {