Skip to content

Commit a4ff173

Browse files
committed
check memory allocations for failure in recent collections module
1 parent 2910d2a commit a4ff173

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/libs/recentcollect.c

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -276,13 +276,16 @@ void _menuitem_preferences(GtkMenuItem *menuitem, dt_lib_module_t *self)
276276
GtkWidget *box = GTK_WIDGET(d->box);
277277
dt_lib_recentcollect_item_t *item
278278
= (dt_lib_recentcollect_item_t *)malloc(sizeof(dt_lib_recentcollect_item_t));
279-
d->items = g_list_append(d->items, item);
280-
item->button = gtk_button_new();
281-
gtk_box_pack_start(GTK_BOX(box), item->button, FALSE, TRUE, 0);
282-
g_signal_connect(G_OBJECT(item->button), "clicked", G_CALLBACK(_button_pressed), (gpointer)self);
283-
gtk_widget_set_no_show_all(item->button, TRUE);
284-
gtk_widget_set_name(GTK_WIDGET(item->button), "recent-collection-button");
285-
gtk_widget_set_visible(item->button, FALSE);
279+
if(item)
280+
{
281+
d->items = g_list_append(d->items, item);
282+
item->button = gtk_button_new();
283+
gtk_box_pack_start(GTK_BOX(box), item->button, FALSE, TRUE, 0);
284+
g_signal_connect(G_OBJECT(item->button), "clicked", G_CALLBACK(_button_pressed), (gpointer)self);
285+
gtk_widget_set_no_show_all(item->button, TRUE);
286+
gtk_widget_set_name(GTK_WIDGET(item->button), "recent-collection-button");
287+
gtk_widget_set_visible(item->button, FALSE);
288+
}
286289
}
287290
}
288291

0 commit comments

Comments
 (0)