Skip to content

docs: fix fastapi ext demo #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2025

Conversation

jseguillon
Copy link
Contributor

@jseguillon jseguillon commented Jan 30, 2025

Description

Fix fastapi ext demo:

@@ -47,7 +47,7 @@ class RawEventModel(BaseModel):
 
 class User(BaseModel):
     id: int
-    name = 'Jane Doe'
+    name: str
 

With current demo, pydantic fails with "A non-annotated attribute was detected" as described in issue ref

Issue reference

#775

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Joël Séguillon <joel.seguillon@gmail.com>
@jseguillon jseguillon requested review from a team as code owners January 30, 2025 11:55
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (bffb749) to head (c45c233).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   86.63%   86.40%   -0.23%     
==========================================
  Files          84       89       +5     
  Lines        4473     5106     +633     
==========================================
+ Hits         3875     4412     +537     
- Misses        598      694      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale Issue marked as stale by Dapr Bot label Jun 21, 2025
@dapr-bot dapr-bot removed the stale Issue marked as stale by Dapr Bot label Jun 24, 2025
@elena-kolevska elena-kolevska merged commit 147f1c4 into dapr:main Jun 24, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants