Skip to content

Commit 8b82a66

Browse files
committed
net: sched: Fix use after free in red_enqueue()
jira VULN-66495 cve CVE-2022-49921 commit-author Dan Carpenter <dan.carpenter@oracle.com> commit 8bdc2ac We can't use "skb" again after passing it to qdisc_enqueue(). This is basically identical to commit 2f09707 ("sch_sfb: Also store skb len before calling child enqueue"). Fixes: d7f4f33 ("sch_red: update backlog as well") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> (cherry picked from commit 8bdc2ac) Signed-off-by: Anmol Jain <ajain@ciq.com>
1 parent ccfd614 commit 8b82a66

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

net/sched/sch_red.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ static int red_enqueue(struct sk_buff *skb, struct Qdisc *sch,
6262
{
6363
struct red_sched_data *q = qdisc_priv(sch);
6464
struct Qdisc *child = q->qdisc;
65+
unsigned int len;
6566
int ret;
6667

6768
q->vars.qavg = red_calc_qavg(&q->parms,
@@ -97,9 +98,10 @@ static int red_enqueue(struct sk_buff *skb, struct Qdisc *sch,
9798
break;
9899
}
99100

101+
len = qdisc_pkt_len(skb);
100102
ret = qdisc_enqueue(skb, child, to_free);
101103
if (likely(ret == NET_XMIT_SUCCESS)) {
102-
qdisc_qstats_backlog_inc(sch, skb);
104+
sch->qstats.backlog += len;
103105
sch->q.qlen++;
104106
} else if (net_xmit_drop_count(ret)) {
105107
q->stats.pdrop++;

0 commit comments

Comments
 (0)