Skip to content

Commit 529dfff

Browse files
author
Gavin Shan
committed
KVM: arm64: Explicitly treat routing entry type changes as changes
JIRA: https://issues.redhat.com/browse/RHEL-93666 Explicitly treat type differences as GSI routing changes, as comparing MSI data between two entries could get a false negative, e.g. if userspace changed the type but left the type-specific data as- Note, the same bug was fixed in x86 by commit bcda70c ("KVM: x86: Explicitly treat routing entry type changes as changes"). Fixes: 4bf3693 ("KVM: arm64: Unmap vLPIs affected by changes to GSI routing information") Signed-off-by: Sean Christopherson <seanjc@google.com> Reviewed-by: Oliver Upton <oliver.upton@linux.dev> Link: https://lore.kernel.org/r/20250611224604.313496-3-seanjc@google.com Signed-off-by: Marc Zyngier <maz@kernel.org> (cherry picked from commit 1fbe686) Signed-off-by: Gavin Shan <gshan@redhat.com>
1 parent 55bb888 commit 529dfff

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

arch/arm64/kvm/arm.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2758,7 +2758,8 @@ void kvm_arch_irq_bypass_del_producer(struct irq_bypass_consumer *cons,
27582758
bool kvm_arch_irqfd_route_changed(struct kvm_kernel_irq_routing_entry *old,
27592759
struct kvm_kernel_irq_routing_entry *new)
27602760
{
2761-
if (new->type != KVM_IRQ_ROUTING_MSI)
2761+
if (old->type != KVM_IRQ_ROUTING_MSI ||
2762+
new->type != KVM_IRQ_ROUTING_MSI)
27622763
return true;
27632764

27642765
return memcmp(&old->msi, &new->msi, sizeof(new->msi));

0 commit comments

Comments
 (0)