Skip to content

Commit 0a057db

Browse files
committed
tun: add missing verification for short frame
jira VULN-9004 cve CVE-2024-41091 commit-author Dongli Zhang <dongli.zhang@oracle.com> commit 0495848 The cited commit missed to check against the validity of the frame length in the tun_xdp_one() path, which could cause a corrupted skb to be sent downstack. Even before the skb is transmitted, the tun_xdp_one-->eth_type_trans() may access the Ethernet header although it can be less than ETH_HLEN. Once transmitted, this could either cause out-of-bound access beyond the actual length, or confuse the underlayer with incorrect or inconsistent header length in the skb metadata. In the alternative path, tun_get_user() already prohibits short frame which has the length less than Ethernet header size from being transmitted for IFF_TAP. This is to drop any frame shorter than the Ethernet header size just like how tun_get_user() does. CVE: CVE-2024-41091 Inspired-by: https://lore.kernel.org/netdev/1717026141-25716-1-git-send-email-si-wei.liu@oracle.com/ Fixes: 043d222 ("tuntap: accept an array of XDP buffs through sendmsg()") Cc: stable@vger.kernel.org Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com> Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com> Reviewed-by: Willem de Bruijn <willemb@google.com> Reviewed-by: Paolo Abeni <pabeni@redhat.com> Reviewed-by: Jason Wang <jasowang@redhat.com> Link: https://patch.msgid.link/20240724170452.16837-3-dongli.zhang@oracle.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> (cherry picked from commit 0495848) Signed-off-by: Anmol Jain <ajain@ciq.com>
1 parent f4e668d commit 0a057db

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/net/tun.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2480,6 +2480,9 @@ static int tun_xdp_one(struct tun_struct *tun,
24802480
bool skb_xdp = false;
24812481
struct page *page;
24822482

2483+
if (unlikely(datasize < ETH_HLEN))
2484+
return -EINVAL;
2485+
24832486
xdp_prog = rcu_dereference(tun->xdp_prog);
24842487
if (xdp_prog) {
24852488
if (gso->gso_type) {

0 commit comments

Comments
 (0)