fix: [GROOT-1314] fix broken pagination for taxonomy requests #2701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After introducing the taxonomy plain client to the user interface, we found that paginated requests were broken.
This is because on next page requests, we were parsing query params manually and passing an empty object to axios as query params. When this happens, axios automatically appends a
?to the end of the "base" url. The "base" url in our case already contains query params, so this was leading to the last url param containing an additional?, breaking requests.Description
This PR makes it so that in these scenarios, we pass
undefinedinstead of{}to axios.Motivation and Context
Screen.Recording.2025-07-18.at.13.22.37.mov