Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update role types to reflect documentation and better reflect return values from the api.
Description
Adds string to the ContentModel type so it can accept the value "all". When retrieving roles using the apis, the ContentModel is set to "all" but when creating them, you are forced to use an array - ["all"].
Adds an action type to allow better typing and support for the "access" action. Exports the type as it's quite useful. Renamed it to prevent clashes/make it clear what it's used for.
Also, there is some confusion about the not operator. In the documentation here, it says "You can specify nested constraints for and, or, not". When referencing the table of examples, it states that not can only accept one constraint as an argument. I have personally concluded that not can be used for both, would it be possible to confirm this and possibly update the documentation?
Motivation and Context
This change fixes a bug wth the ContentModel permission not accepting a string and adds access as an action type for writting environment based policies.
Checklist (check all before merging)
When adding a new method:
./lib/export-types.ts