fix(cli): raise exception instead of skipping an invalid error code

Author: bearomorphism

commitizen/cli.py

@@ -583,11 +583,12 @@ def parse_no_raise(comma_separated_no_raise: str) -> list[int]:
     Receives digits and strings and outputs the parsed integer which
     represents the exit code found in exceptions.
     """
-    return [
-        code.value
-        for s in comma_separated_no_raise.split(",")
-        if (code := ExitCode.from_str(s)) is not None
-    ]
+    try:
+        return [ExitCode.from_str(s).value for s in comma_separated_no_raise.split(",")]
+    except (KeyError, ValueError) as e:
+        raise InvalidCommandArgumentError(
+            f"Invalid no_raise value `{comma_separated_no_raise}`. "
+        ) from e
 
 
 if TYPE_CHECKING:

commitizen/exceptions.py

@@ -42,21 +42,10 @@ class ExitCode(IntEnum):
     COMMIT_MESSAGE_LENGTH_LIMIT_EXCEEDED = 32
 
     @classmethod
-    def from_str(cls, value: str) -> ExitCode | None:
+    def from_str(cls, value: str) -> ExitCode:
         if value.isdecimal():
-            try:
-                return cls(int(value))
-            except ValueError:
-                out.warn(
-                    f"WARN: no_raise value `{value}` is not a valid exit code. Skipping."
-                )
-                return None
-
-        try:
-            return cls[value.strip()]
-        except KeyError:
-            out.warn(f"WARN: no_raise key `{value}` does not exist. Skipping.")
-            return None
+            return cls(int(value))
+        return cls[value.strip()]
 
 
 class CommitizenException(Exception):

tests/test_cli.py

@@ -161,10 +161,13 @@ def test_parse_no_raise_mix_integer_error_code():
     assert result == [1, 2, 3, 4]
 
 
-def test_parse_no_raise_mix_invalid_arg_is_skipped():
+def test_parse_no_raise_mix_invalid_arg_with_error():
     input_str = "NO_COMMITIZEN_FOUND,2,nothing,4"
-    result = cli.parse_no_raise(input_str)
-    assert result == [1, 2, 4]
+    with pytest.raises(InvalidCommandArgumentError) as excinfo:
+        cli.parse_no_raise(input_str)
+    assert "Invalid no_raise value `NO_COMMITIZEN_FOUND,2,nothing,4`" in str(
+        excinfo.value
+    )
 
 
 def test_unknown_args_raises(mocker: MockFixture):

tests/test_exceptions.py

@@ -1,3 +1,5 @@
+import pytest
+
 from commitizen.exceptions import ExitCode
 
 
@@ -26,7 +28,11 @@ def test_from_str_with_whitespace():
 
 def test_from_str_with_invalid_values():
     """Test from_str with invalid values."""
-    assert ExitCode.from_str("invalid_name") is None
-    assert ExitCode.from_str("999") is None  # Out of range decimal
-    assert ExitCode.from_str("") is None
-    assert ExitCode.from_str(" ") is None
+    with pytest.raises(KeyError):
+        ExitCode.from_str("invalid_name")
+    with pytest.raises(ValueError):
+        ExitCode.from_str("999")  # Out of range decimal
+    with pytest.raises(KeyError):
+        ExitCode.from_str("")
+    with pytest.raises(KeyError):
+        ExitCode.from_str(" ")