Skip to content
This repository was archived by the owner on Feb 11, 2021. It is now read-only.

Commit 32917a7

Browse files
committed
Fixes for prime examples.
Fixed order of removing from queue before checking number. Fixed calculation of prime.
1 parent 56d5988 commit 32917a7

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

examples/simple/actions/primes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
export const ADD_PRIME = 'ADD_PRIME';
3-
export const ADD_NON_PRIME = 'ADD_PRIME';
3+
export const ADD_NON_PRIME = 'ADD_NON_PRIME';
44
export const ADD_QUEUE_NUMBER = 'ADD_QUEUE_NUMBER';
55
export const REMOVE_QUEUE_NUMBER = 'REMOVE_QUEUE_NUMBER';
66

examples/simple/middleware/primesMiddleware.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ function checkNextPrime( queue, dispatch ) {
2121
console.log( 'checking next number ' + number );
2222
checkPrime( number ).then(
2323
( isPrime ) => {
24+
dispatch( removeQueueNumber( number ) );
2425
if ( isPrime ) {
2526
console.log( 'number ' + number + ' is prime!' );
2627
dispatch( addPrime( number ) );
2728
} else {
2829
console.log( 'number ' + number + ' is not prime!' );
2930
dispatch( addNonPrime( number ) );
3031
}
31-
dispatch( removeQueueNumber( number ) );
3232
}
3333
);
3434
}
@@ -38,14 +38,15 @@ function checkPrime( number ) {
3838
return new Promise(
3939
( resolve, reject ) => {
4040

41-
for ( let i = 0; i < number; i++ ) {
41+
for ( let i = 2; i < number; i++ ) {
4242
if ( Number.isInteger( number / i ) ) {
43-
resolve( true );
43+
console.log( number + " is divisible by " + i );
44+
resolve( false );
4445
}
4546
}
4647

4748
// No numbers below this one divided cleanly, it's prime.
48-
resolve( false );
49+
resolve( true );
4950
}
5051
);
5152
}

0 commit comments

Comments
 (0)