Skip to content

Commit 8546002

Browse files
committed
Typehint the arguments for criteria
1 parent da10080 commit 8546002

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/Criteria/OnlyTrashedCriteria.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use CodeOfDigital\CacheRepository\Contracts\CriteriaInterface;
66
use CodeOfDigital\CacheRepository\Contracts\RepositoryInterface;
77
use CodeOfDigital\CacheRepository\Exceptions\RepositoryException;
8+
use Illuminate\Database\Eloquent\Builder;
89
use Illuminate\Database\Eloquent\Model;
910
use Illuminate\Database\Eloquent\SoftDeletes;
1011

@@ -13,12 +14,12 @@ class OnlyTrashedCriteria implements CriteriaInterface
1314
/**
1415
* Apply conditions into current query building
1516
*
16-
* @param Model $model
17+
* @param Model|Builder $model
1718
* @param RepositoryInterface $repository
1819
* @return mixed
1920
* @throws RepositoryException
2021
*/
21-
public function apply(Model $model, RepositoryInterface $repository): mixed
22+
public function apply(Model|Builder $model, RepositoryInterface $repository): mixed
2223
{
2324
if (!in_array(SoftDeletes::class, class_uses($model)))
2425
throw new RepositoryException('Model must implement SoftDeletes Trait to use this criteria.');

src/Criteria/WithTrashedCriteria.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use CodeOfDigital\CacheRepository\Contracts\CriteriaInterface;
66
use CodeOfDigital\CacheRepository\Contracts\RepositoryInterface;
77
use CodeOfDigital\CacheRepository\Exceptions\RepositoryException;
8+
use Illuminate\Database\Eloquent\Builder;
89
use Illuminate\Database\Eloquent\Model;
910
use Illuminate\Database\Eloquent\SoftDeletes;
1011

@@ -13,12 +14,12 @@ class WithTrashedCriteria implements CriteriaInterface
1314
/**
1415
* Apply conditions into current query building
1516
*
16-
* @param Model $model
17+
* @param Model|Builder $model
1718
* @param RepositoryInterface $repository
1819
* @return mixed
1920
* @throws RepositoryException
2021
*/
21-
public function apply(Model $model, RepositoryInterface $repository): mixed
22+
public function apply(Model|Builder $model, RepositoryInterface $repository): mixed
2223
{
2324
if (!in_array(SoftDeletes::class, class_uses($model)))
2425
throw new RepositoryException('Model must implement SoftDeletes Trait to use this criteria.');

0 commit comments

Comments
 (0)