From 17ff1c7748c7674c161f884640e6abb421d45a50 Mon Sep 17 00:00:00 2001 From: Nawras Bukhari <63796900+NawrasBukhari@users.noreply.github.com> Date: Wed, 14 Dec 2022 03:16:30 +0600 Subject: [PATCH] fix %5C issue in the call #408 when I debugged the issue it was with the coma separator constant so when I changed it worked --- .../GithubRepositoryTypes/GithubBranchType.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/SourceRepositoryTypes/GithubRepositoryTypes/GithubBranchType.php b/src/SourceRepositoryTypes/GithubRepositoryTypes/GithubBranchType.php index eeafe03..6a7a552 100644 --- a/src/SourceRepositoryTypes/GithubRepositoryTypes/GithubBranchType.php +++ b/src/SourceRepositoryTypes/GithubRepositoryTypes/GithubBranchType.php @@ -92,10 +92,10 @@ public function getVersionAvailable(string $prepend = '', string $append = ''): final public function getReleases(): Response { - $url = DIRECTORY_SEPARATOR.'repos' - .DIRECTORY_SEPARATOR.$this->config['repository_vendor'] - .DIRECTORY_SEPARATOR.$this->config['repository_name'] - .DIRECTORY_SEPARATOR.'commits' + $url = '/'.'repos' + .'/'.$this->config['repository_vendor'] + .'/'.$this->config['repository_name'] + .'/'.'commits' .'?sha='.$this->config['use_branch']; $headers = []; @@ -111,10 +111,10 @@ final public function getReleases(): Response private function generateArchiveUrl(string $name): string { - return DIRECTORY_SEPARATOR.'repos' - .DIRECTORY_SEPARATOR.$this->config['repository_vendor'] - .DIRECTORY_SEPARATOR.$this->config['repository_name'] - .DIRECTORY_SEPARATOR.'zipball' - .DIRECTORY_SEPARATOR.$name; + return '/'.'repos' + .'/'.$this->config['repository_vendor'] + .'/'.$this->config['repository_name'] + .'/'.'zipball' + .'/'.$name; } }